fix: clean up slip 44 service logic #7626
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
salimtb
force-pushed
the
fix/clean-up-slip-44-logic
branch
from
d039284 to
e368883
Compare
salimtb
changed the title
bergarces
reviewed
Jan 14, 2026
|
|
||
| return undefined; | ||
| // Default to 60 (Ethereum) for EVM networks without specific mapping | ||
| return 60; |
Contributor
There was a problem hiding this comment.
💀
Is undefined not better here? If not, at least the behaviour is very clear here.
Contributor
There was a problem hiding this comment.
Forget what I said, I see now that it defaulted to 60 anyway in the consumer.
Contributor
Author
There was a problem hiding this comment.
I don’t think undefined is better here, because it pushes the ambiguity to runtime.
Defaulting to slip44:60 makes the behavior explicit and deterministic for EVM chains, which matches how wallets already derive and sign accounts. An undefined value would still require downstream logic to infer or guess the coin type, and that inference would almost certainly end up being 60 anyway.
bergarces
reviewed
Jan 14, 2026
packages/network-enablement-controller/src/NetworkEnablementController.ts
Outdated
Show resolved
Hide resolved
Contributor
Author
|
@metamaskbot publish-preview |
Contributor
|
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions. |
bergarces
approved these changes
Jan 14, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
The
Slip44Servicewas introduced in #7609 to look up SLIP-44 coin types for building native asset identifiers (CAIP-19). However, the initial API had some complexity that wasn't necessary:The
getSlip44ByChainIdmethod had an optionalsymbolparameter for fallback, but this fallback logic was confusing since EVM networks should use chain ID lookup and non-EVM networks should use symbol lookup - mixing them in one method added unnecessary complexity.The method could return
undefinedfor unknown EVM chains, but since EVM networks are all Ethereum-compatible, defaulting to 60 (Ethereum's SLIP-44 coin type) is a reasonable and safe default.The
getSlip44Entrymethod andSlip44Entrytype export weren't being used anywhere.This PR cleans up the service by:
getSlip44ByChainId→getEvmSlip44to make it explicit that it's for EVM networks onlysymbolfallback parameter (usegetSlip44BySymboldirectly for non-EVM networks)60(Ethereum) as the default for unknown EVM chain IDs instead ofundefinedgetSlip44Entrymethod andSlip44Entrytype exportNetworkEnablementControllerto no longer pass the native currency symbol to the lookup functionReferences
Checklist
Note
Streamlines SLIP-44 resolution and aligns controller usage.
getSlip44ByChainId→getEvmSlip44(EVM-only) and always default to coin type60when unmappedgetSlip44BySymbolonly for non-EVM networksgetSlip44Entryand its type/export; updateservices/index.tsand packageindex.tsexportsNetworkEnablementControllerto callSlip44Service.getEvmSlip44, stop passing native currency to add-network handler, and parse references correctlygetEvmSlip44, update expectations (e.g.,eip155:2→slip44:60), and remove unused entry testsWritten by Cursor Bugbot for commit 47cfb4e. This will update automatically on new commits. Configure here.