-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Add token logo for McDonaldTrumpPepeInu #1670
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| { | ||
| "name": "McDonaldTrumpPepeInu", | ||
| "symbol": "BIGMC", | ||
| "decimals": 18, | ||
| "erc20": true | ||
| } |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| { | ||
| "name": "McDonaldTrumpPepeInu", | ||
| "symbol": "BIGMC", | ||
| "decimals": 18 | ||
| } | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Bug: Token metadata missing required erc20 fieldThe manifest.json is missing the There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Bug: Contract address not in EIP-55 checksum formatThe contract address |
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: Token metadata uses wrong directory structure
The file path uses
metadata/tokens/{address}/manifest.jsonformat, but existing tokens in this repository follow the CAIP-19 format atmetadata/eip155:1/erc20:{address}.json. This non-standard path structure means the token metadata likely won't be recognized or indexed by the application that consumes this repository.