-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Add token logo for McDonaldTrumpPepeInu #1670
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
| "name": "McDonaldTrumpPepeInu", | ||
| "symbol": "BIGMC", | ||
| "decimals": 18 | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: Token metadata uses wrong directory structure
The file path uses metadata/tokens/{address}/manifest.json format, but existing tokens in this repository follow the CAIP-19 format at metadata/eip155:1/erc20:{address}.json. This non-standard path structure means the token metadata likely won't be recognized or indexed by the application that consumes this repository.
| "name": "McDonaldTrumpPepeInu", | ||
| "symbol": "BIGMC", | ||
| "decimals": 18 | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: Token metadata missing required erc20 field
The manifest.json is missing the erc20 field. According to the repository guidelines and all existing token entries, ERC20 tokens must include "erc20": true in their metadata. This omission may cause the token to be incorrectly categorized or ignored by consuming applications.
| "name": "McDonaldTrumpPepeInu", | ||
| "symbol": "BIGMC", | ||
| "decimals": 18 | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: Contract address not in EIP-55 checksum format
The contract address 0x0ce132ed0a46fcb20ae208e827522c9b045d7c4e in the file path is entirely lowercase, which indicates it's not in EIP-55 checksum format. All existing token addresses in this repository use proper EIP-55 checksumming with mixed case (e.g., 0x0000000000085d4780B73119b644AE5ecd22b376). The README explicitly states "The address should be in checksum format or it will not be accepted."
|
Thanks for the review! The metadata path has been updated to the CAIP-19 standard under: The ERC20 flag was added ("erc20": true), and the contract address is now in proper EIP-55 checksum format. Please let me know if anything else needs adjustment. |
This PR adds the official token logo following MetaMask contract-metadata guidelines.
Note
Adds ERC20 token metadata manifests for McDonaldTrumpPepeInu (BIGMC), including name, symbol, decimals, and ERC20 flag.
metadata/eip155/137/erc20/0x0Ce132Ed0A46FcB20aE208E827522C9B045D7C4E/manifest.jsonwithname,symbol,decimals, anderc20: true.metadata/tokens/0x0ce132ed0a46fcb20ae208e827522c9b045d7c4e/manifest.jsonwithname,symbol, anddecimals.Written by Cursor Bugbot for commit 3b0d691. This will update automatically on new commits. Configure here.