-
Notifications
You must be signed in to change notification settings - Fork 10
refactor(stack): use as_file() for package resource copying #937
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(stack): use as_file() for package resource copying #937
Conversation
|
This pull request is part of a stack:
|
Merge ProtectionsYour pull request matches the following merge protections and will not be merged until they are valid. 🟢 🤖 Continuous IntegrationWonderful, this rule succeeded.
🟢 👀 Review RequirementsWonderful, this rule succeeded.
🟢 Enforce conventional commitWonderful, this rule succeeded.Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/
🟢 🔎 ReviewsWonderful, this rule succeeded.
🟢 📕 PR descriptionWonderful, this rule succeeded.
|
🧪 CI InsightsHere's what we observed from your CI run for 82b0e00. 🟢 All jobs passed!But CI Insights is watching 👀 |
5bf5d8b to
b99cacb
Compare
1afef78 to
a8eec96
Compare
Pull request has been modified.
b99cacb to
d31a4b9
Compare
a8eec96 to
173c3d4
Compare
d31a4b9 to
9be7898
Compare
173c3d4 to
26479bc
Compare
9be7898 to
67a94f2
Compare
26479bc to
1509d9b
Compare
|
@jd this pull request is now in conflict 😩 |
Change git hook installation to use importlib.resources.as_file() context manager for copying resources. This ensures compatibility with zip/PEX-style package installations where resources aren't directly accessible as filesystem paths. - Rename _get_script_resource_path() to _get_script_resource() returning Traversable instead of str - Add _get_wrapper_resource() helper - Update _script_needs_update() to accept Traversable - Use as_file() context manager in _install_git_hook() and ensure_hooks_updated() This makes git hook handling consistent with Claude hook handling which already uses as_file(). Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> Change-Id: I0a5ac49101c080fc9cee0ee84fae84c43ec28a64 Claude-Session-Id: 3dabd187-059b-40b7-9a52-a2542a27c752
1509d9b to
82b0e00
Compare
Merge Queue Status✅ The pull request has been merged at 82b0e00 This pull request spent 8 seconds in the queue, including 1 second running CI. Required conditions to merge
|
Change git hook installation to use importlib.resources.as_file()
context manager for copying resources. This ensures compatibility
with zip/PEX-style package installations where resources aren't
directly accessible as filesystem paths.
returning Traversable instead of str
ensure_hooks_updated()
This makes git hook handling consistent with Claude hook handling
which already uses as_file().
Co-Authored-By: Claude Opus 4.5 noreply@anthropic.com