Skip to content

refactor(stack): extract _get_script_resource_path() helper#935

Merged
mergify[bot] merged 1 commit intomainfrom
devs/jd/version-hooks/I565f0651b22e1cc13c66015638df799796d7e819
Jan 27, 2026
Merged

refactor(stack): extract _get_script_resource_path() helper#935
mergify[bot] merged 1 commit intomainfrom
devs/jd/version-hooks/I565f0651b22e1cc13c66015638df799796d7e819

Conversation

@jd
Copy link
Member

@jd jd commented Jan 24, 2026

Consolidate the duplicated script resource path construction into a
single helper function.

Co-Authored-By: Claude Opus 4.5 noreply@anthropic.com

@mergify mergify bot had a problem deploying to Mergify Merge Protections January 24, 2026 17:25 Failure
@jd
Copy link
Member Author

jd commented Jan 24, 2026

This pull request is part of a stack:

  1. refactor(stack): extract _get_script_resource_path() helper (#935) 👈
  2. refactor(stack): use as_file() for package resource copying (#937)

@mergify
Copy link
Contributor

mergify bot commented Jan 24, 2026

Merge Protections

Your pull request matches the following merge protections and will not be merged until they are valid.

🟢 🤖 Continuous Integration

Wonderful, this rule succeeded.
  • all of:
    • check-success=ci-gate

🟢 👀 Review Requirements

Wonderful, this rule succeeded.
  • any of:
    • #approved-reviews-by>=2
    • author = dependabot[bot]
    • author = mergify-ci-bot
    • author = renovate[bot]

🟢 Enforce conventional commit

Wonderful, this rule succeeded.

Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/

  • title ~= ^(fix|feat|docs|style|refactor|perf|test|build|ci|chore|revert)(?:\(.+\))?:

🟢 🔎 Reviews

Wonderful, this rule succeeded.
  • #changes-requested-reviews-by = 0
  • #review-requested = 0
  • #review-threads-unresolved = 0

🟢 📕 PR description

Wonderful, this rule succeeded.
  • body ~= (?ms:.{48,})

@mergify
Copy link
Contributor

mergify bot commented Jan 24, 2026

🧪 CI Insights

Here's what we observed from your CI run for 67a94f2.

🟢 All jobs passed!

But CI Insights is watching 👀

@jd jd force-pushed the devs/jd/version-hooks/I0b88b1f5a7a332665b51fbeda5341c80b2ab40e4 branch from 45260a8 to 41bf5c4 Compare January 25, 2026 13:35
@jd jd force-pushed the devs/jd/version-hooks/I565f0651b22e1cc13c66015638df799796d7e819 branch from 53fa1d6 to ce92b69 Compare January 25, 2026 13:35
@mergify mergify bot had a problem deploying to Mergify Merge Protections January 25, 2026 13:36 Failure
@jd jd force-pushed the devs/jd/version-hooks/I0b88b1f5a7a332665b51fbeda5341c80b2ab40e4 branch from 41bf5c4 to e16a5ee Compare January 25, 2026 14:32
@jd jd force-pushed the devs/jd/version-hooks/I565f0651b22e1cc13c66015638df799796d7e819 branch from ce92b69 to 5bf5d8b Compare January 25, 2026 14:32
@mergify mergify bot had a problem deploying to Mergify Merge Protections January 25, 2026 14:33 Failure
@mergify mergify bot requested a review from a team January 25, 2026 14:34
remyduthu
remyduthu previously approved these changes Jan 26, 2026
@jd jd force-pushed the devs/jd/version-hooks/I0b88b1f5a7a332665b51fbeda5341c80b2ab40e4 branch from e16a5ee to 50c44f7 Compare January 26, 2026 12:53
@jd jd force-pushed the devs/jd/version-hooks/I565f0651b22e1cc13c66015638df799796d7e819 branch from 5bf5d8b to b99cacb Compare January 26, 2026 12:53
@mergify mergify bot dismissed remyduthu’s stale review January 26, 2026 12:53

Pull request has been modified.

@mergify mergify bot had a problem deploying to Mergify Merge Protections January 26, 2026 12:53 Failure
@mergify mergify bot requested a review from a team January 26, 2026 12:55
sileht
sileht previously approved these changes Jan 26, 2026
@jd jd force-pushed the devs/jd/version-hooks/I0b88b1f5a7a332665b51fbeda5341c80b2ab40e4 branch from 50c44f7 to cafc24a Compare January 26, 2026 13:13
@jd jd force-pushed the devs/jd/version-hooks/I565f0651b22e1cc13c66015638df799796d7e819 branch from b99cacb to d31a4b9 Compare January 26, 2026 13:13
@mergify mergify bot dismissed sileht’s stale review January 26, 2026 13:13

Pull request has been modified.

@mergify mergify bot had a problem deploying to Mergify Merge Protections January 26, 2026 13:13 Failure
@mergify mergify bot requested a review from a team January 26, 2026 13:15
@jd jd force-pushed the devs/jd/version-hooks/I0b88b1f5a7a332665b51fbeda5341c80b2ab40e4 branch from cafc24a to 2c041d4 Compare January 26, 2026 15:56
@jd jd force-pushed the devs/jd/version-hooks/I565f0651b22e1cc13c66015638df799796d7e819 branch from d31a4b9 to 9be7898 Compare January 26, 2026 15:57
@mergify mergify bot had a problem deploying to Mergify Merge Protections January 26, 2026 15:57 Failure
Base automatically changed from devs/jd/version-hooks/I0b88b1f5a7a332665b51fbeda5341c80b2ab40e4 to main January 27, 2026 08:13
@mergify
Copy link
Contributor

mergify bot commented Jan 27, 2026

@jd this pull request is now in conflict 😩

@mergify mergify bot added the conflict label Jan 27, 2026
remyduthu
remyduthu previously approved these changes Jan 27, 2026
Consolidate the duplicated script resource path construction into a
single helper function.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Change-Id: I565f0651b22e1cc13c66015638df799796d7e819
Claude-Session-Id: 3dabd187-059b-40b7-9a52-a2542a27c752
@jd jd force-pushed the devs/jd/version-hooks/I565f0651b22e1cc13c66015638df799796d7e819 branch from 9be7898 to 67a94f2 Compare January 27, 2026 09:31
@mergify mergify bot removed the conflict label Jan 27, 2026
@mergify mergify bot dismissed remyduthu’s stale review January 27, 2026 09:31

Pull request has been modified.

@mergify mergify bot deployed to Mergify Merge Protections January 27, 2026 09:31 Active
@mergify
Copy link
Contributor

mergify bot commented Jan 27, 2026

Merge Queue Status

✅ The pull request has been merged at 67a94f2

This pull request spent 7 seconds in the queue, including 1 second running CI.
The checks were run in-place.

Required conditions to merge

@mergify mergify bot merged commit bfa3073 into main Jan 27, 2026
10 checks passed
@mergify mergify bot added the queued label Jan 27, 2026
@mergify mergify bot deleted the devs/jd/version-hooks/I565f0651b22e1cc13c66015638df799796d7e819 branch January 27, 2026 09:44
@mergify mergify bot removed the queued label Jan 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants