Skip to content

optimizer: Fix error condition in normalize_lets#35391

Merged
def- merged 1 commit intoMaterializeInc:mainfrom
def-:pr-fix-error-condition
Mar 10, 2026
Merged

optimizer: Fix error condition in normalize_lets#35391
def- merged 1 commit intoMaterializeInc:mainfrom
def-:pr-fix-error-condition

Conversation

@def-
Copy link
Contributor

@def- def- commented Mar 10, 2026

Introduced in #30429

!a == b is (!a) == b, which doesn't make sense to me, and doesn't fit the comment above.

@def- def- requested review from frankmcsherry and ggevay March 10, 2026 12:19
@def- def- requested a review from a team as a code owner March 10, 2026 12:19
@github-actions
Copy link

Thanks for opening this PR! Here are a few tips to help make the review process smooth for everyone.

PR title guidelines

  • Use imperative mood: "Fix X" not "Fixed X" or "Fixes X"
  • Be specific: "Fix panic in catalog sync when controller restarts" not "Fix bug" or "Update catalog code"
  • Prefix with area if helpful: compute: , storage: , adapter: , sql:

Pre-merge checklist

  • The PR title is descriptive and will make sense in the git log.
  • This PR has adequate test coverage / QA involvement has been duly considered. (trigger-ci for additional test/nightly runs)
  • If this PR includes major user-facing behavior changes, I have pinged the relevant PM to schedule a changelog post.
  • This PR has an associated up-to-date design doc, is a design doc (template), or is sufficiently small to not require a design.
  • If this PR evolves an existing $T ⇔ Proto$T mapping (possibly in a backwards-incompatible way), then it is tagged with a T-proto label.
  • If this PR will require changes to cloud orchestration or tests, there is a companion cloud PR to account for those changes that is tagged with the release-blocker label (example).

Copy link
Contributor

@ggevay ggevay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed, thank you!

@def- def- enabled auto-merge (squash) March 10, 2026 16:10
@def- def- merged commit 0c487b4 into MaterializeInc:main Mar 10, 2026
329 of 332 checks passed
@def- def- deleted the pr-fix-error-condition branch March 10, 2026 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants