optimizer: Fix error condition in normalize_lets (#35391)

def- · web-flow · commit 0c487b44b0dd · 2026-03-10T16:11:20.000Z
Introduced in #30429 `!a == b` is `(!a) == b`, which doesn't make sense to me, and doesn't fit the comment above.
diff --git a/src/transform/src/normalize_lets.rs b/src/transform/src/normalize_lets.rs
@@ -304,7 +304,7 @@ mod support {
             {
                 if let Some(new_type) = types.get(i) {
                     // Assert that the column length has not changed.
-                    if !new_type.column_types.len() == typ.column_types.len() {
+                    if new_type.column_types.len() != typ.column_types.len() {
                         Err(crate::TransformError::Internal(format!(
                             "column lengths do not match: {:?} v {:?}",
                             new_type.column_types, typ.column_types

Original file line number	Diff line number	Diff line change
`@@ -304,7 +304,7 @@ mod support {`
`304`	`304`	`{`
`305`	`305`	`if let Some(new_type) = types.get(i) {`
`306`	`306`	`// Assert that the column length has not changed.`
`307`		`- if !new_type.column_types.len() == typ.column_types.len() {`
	`307`	`+ if new_type.column_types.len() != typ.column_types.len() {`
`308`	`308`	`Err(crate::TransformError::Internal(format!(`
`309`	`309`	`"column lengths do not match: {:?} v {:?}",`
`310`	`310`	`new_type.column_types, typ.column_types`