Skip to content

fix(java): resolve Java executable path using JAVA_HOME or fallback to 'java' #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
GhostTypes merged 2 commits into from
Mar 28, 2026
Merged

fix(java): resolve Java executable path using JAVA_HOME or fallback to 'java' #6

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
df20100
fix(java): resolve Java executable path using JAVA_HOME or fallback t…
Narazaka Mar 26, 2026
1298910
Update src/java/java-process.ts
GhostTypes Mar 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 18 additions & 3 deletions src/java/java-process.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,21 @@
import { spawn } from 'node:child_process';
import path from 'node:path';
import { JavaProcessError } from '../utils/errors.js';
import { logger } from '../utils/logger.js';
import { normalizeOptionalPath, normalizePath } from '../utils/path-converter.js';

/**
* Resolve the Java executable path.
* Prefers JAVA_HOME/bin/java if JAVA_HOME is set, otherwise falls back to 'java' on PATH.
*/
function getJavaExecutable(): string {
const javaHome = process.env.JAVA_HOME;
if (javaHome) {
return path.join(normalizePath(javaHome), 'bin', 'java');
}
return 'java';
}

export interface JavaProcessOptions {
maxMemory?: string; // e.g., "2G"
minMemory?: string; // e.g., "512M"
Expand Down Expand Up @@ -70,7 +83,8 @@ export async function executeJavaProcess(
javaArgs = [...baseJvmArgs, '-jar', normalizedJarPath, ...normalizedArgs];
}

logger.info(`Executing Java: java ${javaArgs.join(' ')}`);
const javaExe = getJavaExecutable();
logger.info(`Executing Java: ${javaExe} ${javaArgs.join(' ')}`);

return new Promise((resolve, reject) => {
const spawnOptions: { stdio: ['ignore', 'pipe', 'pipe']; cwd?: string } = {
Expand All @@ -82,7 +96,7 @@ export async function executeJavaProcess(
spawnOptions.cwd = normalizedCwd;
}

const process = spawn('java', javaArgs, spawnOptions);
const process = spawn(javaExe, javaArgs, spawnOptions);

let stdout = '';
let stderr = '';
Expand Down Expand Up @@ -144,7 +158,8 @@ export async function executeJavaProcess(
*/
export async function getJavaVersion(): Promise<string> {
return new Promise((resolve, reject) => {
const process = spawn('java', ['-version'], { stdio: ['ignore', 'pipe', 'pipe'] });
const javaExe = getJavaExecutable();
const process = spawn(javaExe, ['-version'], { stdio: ['ignore', 'pipe', 'pipe'] });

let output = '';

Expand Down