fix(java): resolve Java executable path using JAVA_HOME or fallback to 'java'#6
Merged
GhostTypes merged 2 commits intoMCDxAI:mainfrom Mar 28, 2026
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a getJavaExecutable helper function to resolve the Java path by prioritizing the JAVA_HOME environment variable over the default system path. The executeJavaProcess and getJavaVersion functions were updated to utilize this new helper. Feedback was provided to use the normalizePath utility when resolving JAVA_HOME to ensure cross-platform compatibility and consistency with other path handling in the codebase.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since Minecraft often requires installing multiple Java versions, it would be nice to be able to select the one set as JAVA_HOME.