Skip to content

Reduce log noise when a spectrum library file is missing or unreadable #1231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
vagisha wants to merge 1 commit into
base: release26.3-SNAPSHOT
Choose a base branch
from
+4 −3
Open

Reduce log noise when a spectrum library file is missing or unreadable #1231

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions src/org/labkey/targetedms/view/spectrum/LibrarySpectrumMatchGetter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,9 +114,10 @@ private static boolean isLargeSpectrumLibrary(Path libPath)
}
catch (IOException e)
{
// If we cannot stat the file it is missing or unreadable, in which case the
// downstream library read will fail too.
LOG.warn("Could not determine size of spectrum library file " + libPath, e);
// The file is missing or unreadable; the downstream library read would fail too.
// Log a single WARN line and keep the stack trace at DEBUG so frequent hits do not flood the primary log.
LOG.warn("Could not determine size of spectrum library file " + libPath + " (" + e.getClass().getSimpleName() + ")");
LOG.debug("Could not determine size of spectrum library file " + libPath, e);
return false;
}
}
Expand Down
Loading