Reduce log noise when a spectrum library file is missing or unreadable#1231
Open
vagisha wants to merge 1 commit into
Open
Reduce log noise when a spectrum library file is missing or unreadable#1231vagisha wants to merge 1 commit into
vagisha wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
After deploying #1226 on PWEB-DR, the code that hides spectrum libraries from guests based on library file size logged a
NoSuchFileExceptionstack trace at WARN on every missing .elib/.blib file (PWEB-DR storage is not in sync with PWEB), filling uplabkey.logvery quickly.Related Pull Requests
Changes