PostgreSQL support for SNPRC modules#888
Merged
labkey-adam merged 18 commits intodevelopfrom Feb 18, 2026
Merged
Conversation
labkey-jeckels
approved these changes
Feb 18, 2026
Contributor
labkey-jeckels
left a comment
labkey-jeckels
left a comment
There was a problem hiding this comment.
I spot checked a few of the tables and all looked OK.
Contributor
labkey-martyp
left a comment
labkey-martyp
left a comment
There was a problem hiding this comment.
A few things to check out.
| RETURN 0; | ||
| END IF; | ||
|
|
||
| trimmed_value := TRIM(value); |
Contributor
There was a problem hiding this comment.
The sql server version also removes internal whitespace. Maybe this should be TRIM(REPLACE(value, ' ', ''))
Comment on lines
19
to
21
| CreatedBy INTEGER NOT NULL, | ||
| Modified TIMESTAMP NOT NULL, | ||
| ModifiedBy INTEGER NOT NULL, |
Contributor
There was a problem hiding this comment.
USERID for createdBy and modifiedBy?
| @@ -0,0 +1 @@ | |||
| DROP VIEW IF EXISTS HL7_GroupNTE; | |||
Contributor
There was a problem hiding this comment.
DROP VIEW IF EXISTS snprc_ehr.HL7_GroupNTE;
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
We want the SNPRC modules to run on PostgreSQL. https://github.com/LabKey/kanban/issues/1577
This adds preliminary support for PostgreSQL. Most SNPRC modules won't run until SND is converted, so key modules have not even been loaded or run. And there are several issues with
snprc_ehr-0.000-25.000.sqlthat need to be addressed or at least reviewed.Also, delete stupid webpart