Remove pgsql marker from a couple SNPRC modules#897
Merged
labkey-adam merged 1 commit intodevelopfrom Feb 26, 2026
Merged
Conversation
labkey-martyp
approved these changes
Feb 26, 2026
Contributor
Author
|
Doing a custom |
Contributor
Author
Looks good... no snd. snprc_r24 is the only snprc module. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
I marked
snprc_ehrandsnprc_geneticsas supporting PostgreSQL during my initial migration work. This caused them to end up in theall_pgdistribution (because all PostgreSQL-supporting modules get pulled in), but they also brought in theirsnddependency, which does not yet support PostgreSQL. That causes problems when trying to run this distribution in production mode. Best to remove thepgsqltag for these modules until they truly support PostgreSQL.I left
snprc_r24tagged withpgsqlbecause it has no dependencies and should run fine on PostgreSQL.Related Pull Requests