Logger: add a log system instead of std::cout or printf#5
Open
Logger: add a log system instead of std::cout or printf#5
Conversation
Contributor
Author
93c4d2a to
99de3af
Compare
|
IMO loglevel parameter overlaps with verbose one. Perhaps verbose should just enable loglevel to debug, and remove the besides that LGTM |
99de3af to
ae84daf
Compare
ae84daf to
9d61627
Compare
9d61627 to
05eb8f3
Compare
ceyusa
reviewed
Apr 24, 2025
ceyusa
reviewed
Apr 24, 2025
ceyusa
reviewed
Apr 24, 2025
ceyusa
reviewed
Apr 24, 2025
ceyusa
reviewed
Apr 24, 2025
ceyusa
reviewed
Apr 24, 2025
ceyusa
reviewed
Apr 24, 2025
c620f07 to
84a3158
Compare
Add a logger with level from ERROR to DEBUG Signed-off-by: Stéphane Cerveau <scerveau@igalia.com>
84a3158 to
e9abec1
Compare
Contributor
Author
|
@zlatinski are you okay to merge this now ? |
Contributor
|
I'm okay with this change, but I would like to ask you to wait until we merge VP9 and Intra refresh changes, please. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a logger with level from ERROR to DEBUG
There are 2 different to call logs:
There are 4 kind of logs: