Conversation
dabrain34
force-pushed
the
dab_testing_framewok_hotfixes
branch
from
101ffee to
df07492
Compare
crmurillo
reviewed
Jan 27, 2026
dabrain34
force-pushed
the
dab_testing_framewok_hotfixes
branch
from
df07492 to
7aea1d3
Compare
crmurillo
reviewed
Jan 28, 2026
dabrain34
force-pushed
the
dab_testing_framewok_hotfixes
branch
from
ea6b838 to
19df939
Compare
ceyusa
reviewed
Jan 29, 2026
dabrain34
force-pushed
the
dab_testing_framewok_hotfixes
branch
from
19df939 to
1d18bd0
Compare
ceyusa
reviewed
Jan 30, 2026
dabrain34
force-pushed
the
dab_testing_framewok_hotfixes
branch
2 times, most recently
from
6811514 to
525a432
Compare
dabrain34
commented
Jan 30, 2026
dabrain34
force-pushed
the
dab_testing_framewok_hotfixes
branch
4 times, most recently
from
84ad3ea to
e789d83
Compare
crmurillo
reviewed
Feb 4, 2026
crmurillo
approved these changes
Feb 4, 2026
ceyusa
reviewed
Feb 4, 2026
Change VulkanVideoProcessor::Initialize return type from int32_t to VkResult for proper Vulkan error handling. This removes the need to negate VkResult values and fixes broken error detection (the previous initResult < 0 check always failed since negated negative VkResult codes become positive). Error cases now return appropriate VkResult codes directly: - VK_ERROR_FEATURE_NOT_PRESENT for invalid video queue - VK_ERROR_VIDEO_PROFILE_CODEC_NOT_SUPPORTED_KHR for unsupported codec - VK_ERROR_FORMAT_NOT_SUPPORTED for unsupported dimensions
- Add VkVideoQueueResult enum with FrameAvailable, NotAvailable, EndOfStream, Error values (avoiding X11 Success macro conflict) - Change GetNextFrame to return enum instead of int32_t with bool* endOfStream - Update OutputFrame and related functions to return bool with optional bytesWritten output parameter - Add proper errno handling in WriteDataToFile with strerror messages - Stop frame processing on file write failure instead of continuing - Add early null checks for mpInfo parameter in ConvertFrameToNv12 and WriteFrameToFileY4M to prevent potential null pointer dereference.
Returns VVS_EXIT_UNSUPPORTED in tests and demos app properly for both encoder and decoder apps.
dabrain34
force-pushed
the
dab_testing_framewok_hotfixes
branch
from
e789d83 to
f52adee
Compare
dabrain34
force-pushed
the
dab_testing_framewok_hotfixes
branch
from
f52adee to
82a32b3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR improves error handling in the video decoder
VulkanVideoProcessor::Initialize now returns VkResult instead of int32_t, enabling proper Vulkan error propagation and avoid issue with -vkResult which was driving to confusion. Now use vkResult as in other init method of the code.
Fixes a bug where unsupported video dimensions weren't detected (negated VkResult codes became positive, always failing the < 0 check)