Skip to content
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@ COSIGN := $(BIN_DIR)/cosign
GIT_SYNC_VERSION := v4.4.2-gke.16__linux_amd64
GIT_SYNC_IMAGE_NAME := gcr.io/config-management-release/git-sync:$(GIT_SYNC_VERSION)

OTELCONTRIBCOL_VERSION := v0.127.0-gke.6
OTELCONTRIBCOL_VERSION := v0.127.0-gke.7

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

This version bump to v0.127.0-gke.7 introduces critical breaking changes. The otel-collector deployment in manifests/templates/otel-collector.yaml must be updated as part of this PR.

  1. Deployment Failure: The collector will fail to start because the --feature-gates=-pkg.translator.prometheus.NormalizeName argument (at manifests/templates/otel-collector.yaml:117) is no longer supported. This feature gate was removed in opentelemetry-collector-contrib v0.93.0. Please remove this argument.

  2. Breaking Metric Name Change: The old configuration disabled trimming of the _ratio suffix from gauge metric names. In the new version, this trimming is enabled by default and cannot be turned off. This will alter metric names and likely break existing dashboards and alerts. This impact needs to be assessed and managed.

Additionally, the comment at manifests/templates/otel-collector.yaml:116 is incorrect and should be removed or updated. It wrongly claims the feature gate enables suffix trimming, when it was actually disabling it.

OTELCONTRIBCOL_IMAGE_NAME := gcr.io/config-management-release/otelcontribcol:$(OTELCONTRIBCOL_VERSION)

# Directory used for staging Docker contexts.
Expand Down