Skip to content

chore: bump otelcontribcol to v0.127.0-gke.7#2072

Closed
Camila-B wants to merge 1 commit intomainfrom
Camila-B-patch-3
Closed

chore: bump otelcontribcol to v0.127.0-gke.7#2072
Camila-B wants to merge 1 commit intomainfrom
Camila-B-patch-3

Conversation

@Camila-B
Copy link
Contributor

No description provided.

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from camila-b. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot requested a review from cowsking February 25, 2026 19:16
@gemini-code-assist
Copy link

Summary of Changes

Hello @Camila-B, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request performs a routine dependency update, specifically incrementing the version of the OpenTelemetry Contrib Collector image used in the project. This ensures the project utilizes the latest stable release of the collector, incorporating any new features, bug fixes, or security patches from the upstream project.

Highlights

  • Dependency Update: The OTELCONTRIBCOL_VERSION in the Makefile has been updated from v0.127.0-gke.6 to v0.127.0-gke.7.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • Makefile
    • Updated the OTELCONTRIBCOL_VERSION variable.
Activity
  • No specific activity has been recorded for this pull request yet.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request bumps the version of otelcontribcol. While this seems like a routine update, it introduces a critical breaking change. The new version of opentelemetry-collector-contrib has removed a feature gate that is currently being used, which will cause the otel-collector deployment to fail upon upgrade. Additionally, the default behavior for metric naming has changed, which is another breaking change that will impact monitoring. Please see the detailed comment on the Makefile for the necessary actions to resolve this.

GIT_SYNC_IMAGE_NAME := gcr.io/config-management-release/git-sync:$(GIT_SYNC_VERSION)

OTELCONTRIBCOL_VERSION := v0.127.0-gke.6
OTELCONTRIBCOL_VERSION := v0.127.0-gke.7

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

This version bump to v0.127.0-gke.7 introduces critical breaking changes. The otel-collector deployment in manifests/templates/otel-collector.yaml must be updated as part of this PR.

  1. Deployment Failure: The collector will fail to start because the --feature-gates=-pkg.translator.prometheus.NormalizeName argument (at manifests/templates/otel-collector.yaml:117) is no longer supported. This feature gate was removed in opentelemetry-collector-contrib v0.93.0. Please remove this argument.

  2. Breaking Metric Name Change: The old configuration disabled trimming of the _ratio suffix from gauge metric names. In the new version, this trimming is enabled by default and cannot be turned off. This will alter metric names and likely break existing dashboards and alerts. This impact needs to be assessed and managed.

Additionally, the comment at manifests/templates/otel-collector.yaml:116 is incorrect and should be removed or updated. It wrongly claims the feature gate enables suffix trimming, when it was actually disabling it.

@tiffanny29631
Copy link
Contributor

Is this from a branch in this repo?

@Camila-B
Copy link
Contributor Author

Yes I created the patch change in Github directly

@tiffanny29631
Copy link
Contributor

I thought #2070 did it?

@Camila-B
Copy link
Contributor Author

You're right I missed that. Closing this PR then

@Camila-B Camila-B closed this Feb 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants