chore: bump otelcontribcol to v0.127.0-gke.7#2072
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Summary of ChangesHello @Camila-B, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request performs a routine dependency update, specifically incrementing the version of the OpenTelemetry Contrib Collector image used in the project. This ensures the project utilizes the latest stable release of the collector, incorporating any new features, bug fixes, or security patches from the upstream project. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request bumps the version of otelcontribcol. While this seems like a routine update, it introduces a critical breaking change. The new version of opentelemetry-collector-contrib has removed a feature gate that is currently being used, which will cause the otel-collector deployment to fail upon upgrade. Additionally, the default behavior for metric naming has changed, which is another breaking change that will impact monitoring. Please see the detailed comment on the Makefile for the necessary actions to resolve this.
| GIT_SYNC_IMAGE_NAME := gcr.io/config-management-release/git-sync:$(GIT_SYNC_VERSION) | ||
|
|
||
| OTELCONTRIBCOL_VERSION := v0.127.0-gke.6 | ||
| OTELCONTRIBCOL_VERSION := v0.127.0-gke.7 |
There was a problem hiding this comment.
This version bump to v0.127.0-gke.7 introduces critical breaking changes. The otel-collector deployment in manifests/templates/otel-collector.yaml must be updated as part of this PR.
-
Deployment Failure: The collector will fail to start because the
--feature-gates=-pkg.translator.prometheus.NormalizeNameargument (atmanifests/templates/otel-collector.yaml:117) is no longer supported. This feature gate was removed inopentelemetry-collector-contrib v0.93.0. Please remove this argument. -
Breaking Metric Name Change: The old configuration disabled trimming of the
_ratiosuffix from gauge metric names. In the new version, this trimming is enabled by default and cannot be turned off. This will alter metric names and likely break existing dashboards and alerts. This impact needs to be assessed and managed.
Additionally, the comment at manifests/templates/otel-collector.yaml:116 is incorrect and should be removed or updated. It wrongly claims the feature gate enables suffix trimming, when it was actually disabling it.
|
Is this from a branch in this repo? |
|
Yes I created the patch change in Github directly |
|
I thought #2070 did it? |
|
You're right I missed that. Closing this PR then |
No description provided.