Skip to content

Cleanup codebase and update to 26.1#1256

Draft
misode wants to merge 55 commits intomasterfrom
update-26.1
Draft

Cleanup codebase and update to 26.1#1256
misode wants to merge 55 commits intomasterfrom
update-26.1

Conversation

@misode
Copy link
Member

@misode misode commented Jan 26, 2026 •
edited
Loading

🫡😢 Discontinued modules

We decided to discontinue some modules with this update. This is necessary to keep the project maintainable and allows us to add new modules without growing endlessly. They are listed here along with some of our reasoning:

  • Better Fire
  • Enchantment Extractors
    • It is able to separate good enchantments and curses
    • Doesn't work for custom enchantments
  • Enderman Support Class
  • Forming Press
    • A worse crafting table (not much initial cost) that gives access to more efficient recipes
  • Heart Canisters
    • This is a boring implementation of extra hearts
  • Mob Curing
    • Feels random
  • Mountaineering
    • Very niche use case, not intuitive to use
  • Poses Pack
    • Hardcoded poses aren't necessary now that poses can be fully customized
  • Potion Swords
    • Mainly used to get wither skulls, which is OP. The rest of the module is unused
  • Relocators
    • Not really used except for liquid tanks
  • XP Storage
    • Does the same as liquid tanks but with no cost
  • Custom Crafters (library)
    • Almost fully replaced by vanilla recipes (see feature changes for exceptions)
  • Trades (library)
    • Modules can now use the villager_trade JSON files to add content

✨ Feature changes

  • With the removal of custom crafters, you can no longer craft boots of ostara from existing leather boots. Removed Flippers of Ostara.
  • Apple trees now only have a 7% chance of appearing in a wandering trader, instead of always being guaranteed

🐛 Fixes

  • Crafted orbs of ankou did not have all the intended properties (max stack to 1, fire resistant, equippable in offhand)
  • The item name of "Potion of Floating" was most likely not working correctly

🚧 TODO

  • Remove overlays
  • Discontinue modules
  • Replace guidebook gm4_recipes with vanilla recipes
  • Update standard crafting video containing custom crafter
  • Change custom_name components into item_name (not sure if we should do this?)
  • Change custom model data to use strings (partially using script)
  • Remove beet.contrib.model_merging
  • Update the docs
  • Update to 26.1 snapshots
  • Update biome-extensions
  • Use villager_trade JSON files for wandering trader customization
  • Replace some technical loot tables with macro functions
  • Remove the modeldata registry
  • Bump minor versions of all modules
  • Remember to create a new 26.1/meta.json file in the release branch, or modify the script to handle this
  • Finish this to-do list

⌛Future work

  • Use timelines, env attributes and a separate world clock for mysterious midnights
  • User atlas text components for recipes in guidebook
  • Rethink how Everstones should work now

Notes

  • Teleportation anchors uses unknown objective gm4_et_data
  • Liquid tanks deposit_one_level and withdraw_one_level have a syntax error with playsound command

@Bloo-dev Bloo-dev added quality-update Improves efficiency or structure without affecting functionality of a module and removed quality-update Improves efficiency or structure without affecting functionality of a module labels Jan 27, 2026
@runcows runcows mentioned this pull request Jan 28, 2026
Merged
misode added 4 commits February 7, 2026 16:28
@misode
Replace custom_name with item name where possible
6f6f5e8 
Not possible in the following cases:
- Any machine block or cart, because custom name is used for place and destroy detection
- SCUBA items, to avoid conflicts with the open PR
- Items with components that override the item_name, for example potion_contents
@misode
Update merged dev RP pack format
6f46a1a
@misode
Remove InvokeOnJsonNbt and other mecha rules
1964e78
@misode
Remove lib trades, refactor apple trees and balloon animals
602d492
@misode misode mentioned this pull request Feb 10, 2026
Closed
This was referenced Feb 23, 2026
Merged
Merged
Merged
BPR02 and others added 20 commits February 28, 2026 09:57
@BPR02
Fix Guidebook Infinite Loop (#1263)
0be96aa
@runcows
26.1 Tag List Updates (#1264)
d2a9ec8 
* delete `#gm4:air`

* Update `#gm4:replaceable`
MC-261616 prevents us from replacing this with the vanilla tag completely

* Deprecate `#gm4:boats` for `#minecraft:boat`

* Remove teleportation_anchors `vehicles` tag as it was unused

* Update teleportation anchors `in_vehicle` predicate to not need to check vehicle type. Tested in game, works as expected.

* Change `#gm4:undead` to `#minecraft:undead` for metallurgy and OoA

* Update `#gm4_tunnel_bores:not_rail_solid` to use `#minecraft:chains`

* Update `#gm4_tunnel_bores:rail_replaceable` to use `#gm4:replaceable`

* Remove required false from all entity type, block, and item tags
@runcows
Replace team hack for selecting mobs with type=!#gm4:non_living (#1270
3def1ca 
)

* Replace team hack for selecting mobs with `type=!#gm4:non_living`

* remaining instances that i missed
@runcows
Use custom module icons for output packs where we have them (#1271)
d9a0aa7
@runcows
Standard Crafting Feature Update (#1260)
d4d14e2 
* Missing advancements

* Enable recipe grouping with vanilla recipes

* Honeycomb recipe

* Dispenser recipe

* Bone Block recipe

* Chest recipe with logs

* Paper recipe in bulk

* Pink Petals recipe

* Cherry Leaves recipe

* Chain recipe in bulk

* Brown Dye recipe

* Green Dye recipe

* Bump Version & add myself to credits

* Rename red sand from red sandstone recipe

* Update red sand conversion recipe to use iron_nugget

* Revert "Paper recipe in bulk"

This reverts commit 7b09d6d.
@BPR02 @Bloo-dev
Improve Guidebook Item Resolver (#1276)
a77c069 
* fix guidebook item resolver

- supports non-vanilla tags
- supports {"id": "...", "required": false} entries in item tags (previously assumed strings)

* fix function call

* fix the other function call

* support non-namespaced tags

* revert standard crafting change

(used for testing)

* remove duplicate logic

* avoid redundant string mutation

* prevent infinite loop for item tag cycle

* set maxsplit when splitting item tag

Co-authored-by: Bloo <git@bloo.boo>

---------

Co-authored-by: Bloo <git@bloo.boo>
@misode
Merge branch 'master' of https://github.com/Gamemode4Dev/GM4_Datapacks …
2582977 
…into update-26.1
@misode
Add debug message to guidebook item resolver
b9e1e23
@misode
Attempt to fix guidebook item resolver
5c2278d
@runcows
Sweethearts code cleanup (#1267)
db3c936 
* Update donor damage to use `/damage`

* Remove recipient non-sneaking requirement

* Little bit of recipient logic refactoring

* Update function headers

* Update predicate to support offhand

* Update guidebook to reflect wither roses do actually work

* fix: 2 players being valid donors

* Rename attributes

* change damage to magic

* change predicate to use slots

* remove any of
@runcows
Fix some readme typos (#1278)
ac81066
@runcows
26.1 time query day repetition (#1279)
0ebdf07 
* raw + repetition + require bolt

* add todo
@runcows @misode
Calling Bell: refactor to use advancements instead of scoreboard chec…
8e496a5 
…ks (#1274)

* Advancement trigger refactor

* add bolt to make the build work
:/

* pack test any_block_use issue again D:

* Invert hitbox check to avoid extra function

---------

Co-authored-by: Misode <misoloo64@gmail.com>
@runcows
Lib Hooked Entity (#1259)
f50e49c 
* Update lib readme github links

* Add lib_hooked_entity

* Update Reeling Rods to use lib_hooked_entity

* change smithed pack id to not be null

* Reorganize generated file locations

* Update generated comment

* Move adventure check to reeling rods

* Fix typos in readme
@TheThanathor @Bloo-dev
Desire Lines - update conversion chances (#1266)
a00f75e 
* update chances

- lowered sprinting penalty
- raised falling penalty
- coarse dirt conversion requires dirt on at least 1 side
- foliage destruction requires coarse dirt conversion

* properly position predicate check

* increase falling probability

* Make "Considerations" Comment More Accurate

* add requested changes

---------

Co-authored-by: Bloo <git@bloo.boo>
@runcows
Disassemblers: Migrate from armor stand to item display (#1273)
971c84a 
* Move placement to a single function that does all rotations

* Transfer logic to forceload armor stand

* Migrate armor stand to item display

* Add comment reminding us to remove the armor stand clean up

* Macro naming changes

* ive suffered enough

* revert version bump
@misode
Merge branch 'master' into update-26.1
7053b14
@runcows
Smelteries: Migrate from armor stands to item displays (#1272)
1d4d901 
* Move placement to a single function that does all rotations

* Item display migration + move entities to center of smeltery

* Remove `gm4_smelt_id` it is no longer needed with everything in the same place

* Upgrade path adjustments

* update comment on upgrade path

* increment entity version

* Macro naming changes

* Update destroy.mcfunction with TODO to clean up legacy commands later

* add me to credit :D

* revert version bump
@runcows
Teleportation Anchors: replace display armor stand with item display (#…
00d9f9e 
…1269)

* Teleportation Anchors: replace display armor stand with item display

* Shift item displays to center of block

* Update destroy_anchor.mcfunction with TODO reminder

* Update destroy_jammer.mcfunction with TODO reminder

* yipee credit

* revert version bump
@runcows
Replace random_patch feature type (#1281)
8f2cf92 
* replace `random_patch`

* fully replace the configured features and do this properly
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@misode @Bloo-dev @runcows @BPR02 @TheThanathor