Disassemblers: Migrate from armor stand to item display#1273
Merged
misode merged 7 commits intoGamemode4Dev:update-26.1from Mar 21, 2026
Merged
Disassemblers: Migrate from armor stand to item display#1273misode merged 7 commits intoGamemode4Dev:update-26.1from
misode merged 7 commits intoGamemode4Dev:update-26.1from
Conversation
misode
reviewed
Feb 25, 2026
Member
misode
left a comment
misode
left a comment
There was a problem hiding this comment.
Mostly some stylistic comments.
I actually quite like the macro approach here. The macro will always be cached and it's not super complicated with bolt or jinja.
gm4_disassemblers/data/gm4_disassemblers/function/machine/place_rotated.mcfunction
Outdated
Show resolved
Hide resolved
| # run via upgrade paths util | ||
|
|
||
| execute as @e[type=armor_stand,tag=gm4_disassembler_stand] at @s positioned ~ ~0.4 ~ \ | ||
| run function gm4_disassemblers:upgrade_paths/2.6/item_display |
Member
There was a problem hiding this comment.
I don't think we should start adding random line continuations like these. Mcfunctions always have had very long lines so your editor should already be wrapping lines imo.
Contributor
Author
There was a problem hiding this comment.
I have bad news for you. I've done this in many places that are already merged 😅
It's also not entirely random, I mainly use it to separate out the execute sub commands from the command that gets run at the end
gm4_disassemblers/data/gm4_disassemblers/function/machine/destroy.mcfunction
Show resolved
Hide resolved
misode
approved these changes
Feb 25, 2026
Bloo-dev
added
the
quality-update
misode
added
tested
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces armor stands with item displays.
Resolves a visual bug with the resource pack, where the disassembler texture doesn't fit the block correctly.
Item display is located at the center of the disassembler. Entity version has been incremented.
The caller loot table now runs on the forceloaded armor stand.
Similar to #1272, this also included is a change to the placement function, moving from 6 functions, one for each cardinal direction, to one which uses macros to control the rotation changes.
There is an included upgrade path, I've tested it in game and it works as expected.
Due to the upgrade path, the minor version has been bumped. This is of note for #1256 where we want to bump all minor versions anyway.