[codex] harden bridge lockbox settlement spine#110
Conversation
|
HQ review note, 2026-05-13: this draft appears to match the #103 contracts/settlement lane and stays within contracts/tests/script/docs/bridge ownership. Please link issue #103 in the PR body before merge. Merge order: after the HQ integration/status PR refreshes the full-L1 map, and before bridge relayer #104 depends on the finalized event schema. Main review focus: avoid creating a second runtime or bridge object model; keep FlowChainSettlementSpine as optional settlement/event support and coordinate event semantics with #104. |
|
HQ review note (2026-05-14): this contracts PR is adjacent to #131 but does not resolve it as currently evidenced. The PR validation says Slither was optional and not installed on PATH, while #131 is specifically about exact product/L1 E2E failing when local Slither is present and reports BaseBridgeLockbox.releaseNative findings. If this PR is intended to close #131, please refresh/rebase and include explicit evidence for |
Summary
BaseBridgeLockboxwith explicit release authority, deposit records, schema-bound deposit and release IDs, release replay guards, per-deposit remaining accounting, nonzero release evidence, token-match checks, and a small reentrancy guard.FlowChainSettlementSpineas a compact local/test commitment event spine for FlowChain object commitments, including bridge-deposit object support for indexer/verifier and bridge agents.DeployBridgeSpine.s.solfor Anvil/Base Sepolia dry-run testing with explicit environment variables, and documented the stable bridge and settlement event schema indocs/bridge/FLOWCHAIN_BASE_BRIDGE_POC.md.Scope
Primary issue: none supplied; this follows the contracts/settlement-spine operator mission.
Allowed folders touched:
contracts/tests/script/docs/bridge/Forbidden folders not touched:
services/apps/crates/crypto/hardware/Worktree path:
E:\FlowMemory\flowmemory-contractsValidation
forge test --match-path tests/bridge/BaseBridgeLockbox.t.solpassed: 15 tests.forge testpassed: 77 tests.npm run contracts:hardeningpassed: build plus 77 Foundry tests. Slither was optional and not installed on PATH.git diff --checkpassed.git diff --check origin/main...HEADpassed.Risks And Follow-Ups
services/; the stable event schema is documented for the bridge relayer handoff.HQ Required Review Metadata (2026-05-14)
Issue status: Refs #103
Worktree / branch ownership: E:\FlowMemory\flowmemory-contracts
Allowed folders: contracts/, contracts/bridge/, tests/, script/, docs/bridge/
Forbidden folders: services/, crypto/, crates/, apps/dashboard/, hardware/
Exact checks recorded:
HQ readiness: Draft; merge state DIRTY; coordinate bridge event/schema vocabulary with [codex] Build bridge relayer credit handoff smoke #113 before merge.