-
Notifications
You must be signed in to change notification settings - Fork 0
Fix overflow buttons styling in Vaadin 25 #20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
4bc4d08
build(demo): upgrade commons-demo to 5.1.0
paodb 7b821ee
ci: upgrade Vaadin to 25.0.3 in v25 profile
paodb aee0fc5
fix: update styles for buttons in overflow for Vaadin 25 compatibility
paodb d322685
feat(demo): add AppShellConfiguratorImpl for Vaadin 25 compatibility
paodb File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
52 changes: 52 additions & 0 deletions
52
src/main/resources/META-INF/frontend/styles/fc-days-of-week-selector.css
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,52 @@ | ||
| /*- | ||
| * #%L | ||
| * Day of Week Selector Add-on | ||
| * %% | ||
| * Copyright (C) 2023 - 2026 Flowing Code | ||
| * %% | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| * #L% | ||
| */ | ||
|
|
||
| /* FOR VAADIN 25 */ | ||
| /* for hidden buttons in the overflow */ | ||
|
|
||
| vaadin-button.fc-days-of-week-selector-button { | ||
| --lumo-button-size: 40px; | ||
| border-radius: 50%; | ||
| width: var(--lumo-button-size); | ||
| max-width: var(--lumo-button-size); | ||
| min-width: var(--lumo-button-size); | ||
| height: var(--lumo-button-size); | ||
| max-height: var(--lumo-button-size); | ||
| min-height: var(--lumo-button-size); | ||
| padding-left: calc(var(--lumo-button-size) / 4); | ||
| padding-right: calc(var(--lumo-button-size) / 4); | ||
| } | ||
|
|
||
| vaadin-button.fc-days-of-week-selector-button[theme~='primary'][disabled]::part(label) { | ||
| opacity: 1; | ||
| } | ||
|
|
||
| vaadin-button.fc-days-of-week-selector-button[disabled].readOnly{ | ||
| color: var(--lumo-secondary-text-color); | ||
| background: transparent; | ||
| } | ||
|
|
||
| vaadin-button.fc-days-of-week-selector-button[theme~='primary'][disabled].readOnly { | ||
| border: var(--vaadin-input-field-readonly-border, 1px dashed var(--lumo-contrast-30pct)); | ||
| } | ||
|
|
||
| vaadin-button.fc-days-of-week-selector-button[focus-ring]{ | ||
| box-shadow: none; | ||
| } | ||
28 changes: 28 additions & 0 deletions
28
src/test/java/com/flowingcode/vaadin/addons/AppShellConfiguratorImpl.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,28 @@ | ||
| /*- | ||
| * #%L | ||
| * Day of Week Selector Add-on | ||
| * %% | ||
| * Copyright (C) 2023 - 2026 Flowing Code | ||
| * %% | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| * #L% | ||
| */ | ||
| package com.flowingcode.vaadin.addons; | ||
|
|
||
| import com.vaadin.flow.component.page.AppShellConfigurator; | ||
| import com.vaadin.flow.theme.Theme; | ||
|
|
||
| @Theme | ||
| public class AppShellConfiguratorImpl implements AppShellConfigurator { | ||
|
|
||
| } |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.