Skip to content

Conversation

@paodb
Copy link
Member

@paodb paodb commented Jan 27, 2026

Close #17

Summary by CodeRabbit

  • Chores

    • Updated Vaadin framework to version 25.0.3
    • Updated Flowingcode commons demo dependency to version 5.1.0
  • Style

    • Enhanced day-of-week selector button styling with improved visual treatment for disabled and read-only states

✏️ Tip: You can customize this high-level summary in your review settings.

@paodb paodb marked this pull request as draft January 27, 2026 19:33
@coderabbitai
Copy link

coderabbitai bot commented Jan 27, 2026

Walkthrough

This PR updates the Day of Week Selector component for Vaadin 25 compatibility by introducing a new theme-scoped CSS stylesheet, updating the component's CSS imports, bumping dependency versions, and adding a test AppShellConfigurator implementation to resolve styling issues with the overflow state.

Changes

Cohort / File(s) Change Summary
Dependency & Build Configuration
pom.xml
Updated flowingcode.commons.demo.version to 5.1.0, bumped vaadin.version to 25.0.3 in v25 profile, and added AppShellConfiguratorImpl.class exclusion in demo-jar packaging
Component Styling
src/main/java/.../DayOfWeekSelector.java, src/main/resources/.../fc-days-of-week-selector.css
Added theme-scoped CSS import annotation for fc-days-of-week-selector.css; introduced new stylesheet defining circular 40px button styling with support for hidden, overflow, disabled, and readOnly states
Test Configuration
src/test/java/.../AppShellConfiguratorImpl.java
Added new public test class implementing Vaadin's AppShellConfigurator with @Theme annotation; class body is empty

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Possibly related PRs

Suggested reviewers

  • javier-godoy
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The PR title accurately describes the main objective: fixing overflow button styling for Vaadin 25 compatibility, which directly addresses issue #17.
Linked Issues check ✅ Passed The code changes successfully address issue #17 by adding CSS styling for the days-of-week selector, upgrading to Vaadin 25.0.3, and adding AppShellConfiguratorImpl for Vaadin 25 compatibility.
Out of Scope Changes check ✅ Passed All changes are directly related to fixing overflow button styling in Vaadin 25. Dependency updates, CSS additions, and demo configuration are all necessary to resolve the reported issue.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@sonarqubecloud
Copy link

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Fix all issues with AI agents
In `@src/main/resources/META-INF/frontend/styles/fc-days-of-week-selector.css`:
- Around line 50-51: The focus-ring override for
vaadin-button.fc-days-of-week-selector-button removes the visible focus
indicator and harms keyboard accessibility; restore a visible focus style by
removing the box-shadow: none override (or replace it with an accessible focus
style) in the vaadin-button.fc-days-of-week-selector-button[focus-ring] rule so
keyboard users can see focus — locate the selector
vaadin-button.fc-days-of-week-selector-button[focus-ring] and either delete that
declaration or set a clear, high-contrast focus outline/box-shadow instead of
none.

@paodb paodb requested a review from javier-godoy January 27, 2026 20:08
@paodb paodb marked this pull request as ready for review January 27, 2026 20:09
@javier-godoy javier-godoy merged commit af6bc0f into master Jan 28, 2026
5 checks passed
@github-project-automation github-project-automation bot moved this from To Do to Pending release in Flowing Code Addons Jan 28, 2026
@javier-godoy javier-godoy deleted the issue-17 branch January 28, 2026 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Pending release

Development

Successfully merging this pull request may close these issues.

Vaadin25: Overflow has wrong style

3 participants