Fix moving cursor to the end of line #729
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
This PR fixes moving the cursor to the end of the line using CMD + ➡ or the End key. To fix this problem, we implemented splitting italic and strikethrough markdown types on the starting and ending syntax of the inline code. Because of the HTML structure, we couldn't split the range directly on the inline code. So similarly to other applications like Slack, the styles are applied to the text inside inline code separately. Thanks to that, we could remove the
display: inline-blockstyle, which was causing the problem with moving the cursor with CMD + ➡Related Issues
Expensify/App#69493
Manual Tests
Linked PRs
#598 (review)