Fix applying styles for inline code syntaxes #732
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmusial
previously approved these changes
Oct 6, 2025
src/rangeUtils.ts
Outdated
| * This includes emojis and syntaxes of inline code blocks. | ||
| */ | ||
| function getRangesToExcludeFormatting(ranges: MarkdownRange[]) { | ||
| function getRangesToExcludeFormatting(ranges: MarkdownRange[]): ExtendedMarkdownRange[] { |
Collaborator
There was a problem hiding this comment.
NAB but i think this should do and you can get rid of #71 then
Suggested change
| function getRangesToExcludeFormatting(ranges: MarkdownRange[]): ExtendedMarkdownRange[] { | |
| function getRangesToExcludeFormatting(ranges: ExtendedMarkdownRange[]): ExtendedMarkdownRange[] { |
Contributor
Author
There was a problem hiding this comment.
If I do that, I will get eslintno-param-reassign. So we need to keep #71. Removing as doesn't seem to me to be worthy, because this function should transform MarkdownRange to ExtendedMarkdownRange. It's more logical to me in that way
tomekzaw
reviewed
Oct 6, 2025
| import {expect} from '@jest/globals'; | ||
| import type {MarkdownRange} from '../commonTypes'; | ||
| import parseExpensiMark from '../parseExpensiMark'; | ||
| import type {ExtendedMarkdownRange} from '../rangeUtils'; |
Collaborator
There was a problem hiding this comment.
Not a huge fan of ExtendedMarkdownRange, why do we need this? Why can't we just extend the existing MarkdownRange type?
Contributor
Author
There was a problem hiding this comment.
In fact, we can 🤔 Changed that in 0169cdc
jmusial
approved these changes
Oct 6, 2025
tomekzaw
approved these changes
Oct 8, 2025
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
This is a follow-up PR to the previous fix for cursor positioning in inline code markdown. Here, I introduced a mechanism that marks opening and closing syntax, and based on that, it extends the range before opening syntax and the range after closing syntax. Thanks to that, styles are continuous
Related Issues
Expensify/App#69493
Manual Tests
Linked PRs
#729