Skip to content

Defer close on fin to async task #106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mathieucarbou merged 1 commit into from
Jan 1, 2026
+1 −5
Merged

Defer close on fin to async task #106

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions src/AsyncTCP.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -468,8 +468,6 @@ int8_t AsyncTCP_detail::tcp_recv(void *arg, struct tcp_pcb *pcb, struct pbuf *pb
e->event = LWIP_TCP_FIN;
e->fin.pcb = pcb;
e->fin.err = err;
// close the PCB in LwIP thread
client->_lwip_fin(e->fin.pcb, e->fin.err);
}

queue_mutex_guard guard;
Expand Down Expand Up @@ -1043,9 +1041,7 @@ int8_t AsyncClient::_lwip_fin(tcp_pcb *pcb, int8_t err) {

// In Async Thread
int8_t AsyncClient::_fin(tcp_pcb *pcb, int8_t err) {
if (_discard_cb) {
_discard_cb(_discard_cb_arg, this);
}
close();
return ERR_OK;
}

Expand Down