Defer close on fin to async task #106
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Defer closing the connection to the async thread when processing a fin event. This allows client connections to process all received data before the connection is terminated.
This can be slightly more expensive for servers who are handling unexpected client termination as they may still process now-pointless ack events, but should have no effect on the normal case (as the server closes when it's done sending). I did a quick perftest with AsyncWebServer and saw no significant performance difference.