Skip to content

Upgrade to pnpm v10.20 & add minimumReleaseAge #181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
VictoriaBeilsten-Edmands wants to merge 1 commit into
base: main
Choose a base branch
from
+56 −11
Open

Upgrade to pnpm v10.20 & add minimumReleaseAge #181

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .npmrc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,2 @@
publish-branch=main
access=public
ignore-scripts=true
10 changes: 6 additions & 4 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,19 +49,19 @@
"storybook:publish": "gh-pages -b storybook/publish -d storybook-static"
},
"dependencies": {
"@mui/icons-material": "^7.0.0",
"keycloak-js": "^26.2.1",
Copy link
Copy Markdown
Member

@akademy akademy May 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Guilherme mentioned moving this to peer. I'm in two minds about it. Do you have an opinion?

(I'm asking under this MR, because I assume it's better to move it to peer so that it is easier to overwrite downstream?)

"react-icons": "^5.3.0",
"utif": "^3.1.0",
"@mui/icons-material": "^7.0.0"
"utif": "^3.1.0"
},
"peerDependencies": {
"@emotion/react": "^11.13.3",
"@emotion/styled": "^11.13.0",
"@jsonforms/core": "^3.7.0",
"@jsonforms/material-renderers": "^3.7.0",
"@jsonforms/react": "^3.7.0",
"@mui/material": "^7.0.0",
"@mui/icons-material": "^7.0.0",
Copy link
Copy Markdown
Member

@akademy akademy May 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We appear to have this both in dependencies and peerDependencies...

I was speaking to Guilherme about something related, and he said icons are fine under dependencies, as they (should) only include the icons we are using.

"@mui/material": "^7.0.0",
"react": "^18.3.1"
},
"devDependencies": {
Expand All @@ -71,6 +71,7 @@
"@babel/preset-typescript": "^7.26.10",
"@chromatic-com/storybook": "^3.2.2",
"@eslint/eslintrc": "^3.2.0",
"@eslint/js": "^10.0.1",
"@rollup/plugin-commonjs": "^28.0.1",
"@rollup/plugin-image": "^3.0.3",
"@rollup/plugin-json": "^6.1.0",
Expand Down Expand Up @@ -120,6 +121,7 @@
},
"pnpm": {
"overrides": {
"fast-uri": "^3.1.2",
"lodash": "^4.18.1",
"qs@>=6.13.0 <6.14.0": "6.14.1",
"js-yaml@^4.1.0": "4.1.1",
Expand All @@ -130,5 +132,5 @@
"webpack@^5.0.0": "5.104.1"
}
},
"packageManager": "pnpm@9.12.3+sha256.24235772cc4ac82a62627cd47f834c72667a2ce87799a846ec4e8e555e2d4b8b"
"packageManager": "pnpm@10.20.0"
}
54 changes: 48 additions & 6 deletions pnpm-lock.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 2 additions & 0 deletions pnpm-workspace.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
ignoreScripts: true
minimumReleaseAge: 10080
Loading