Upgrade to pnpm v10.20 & add minimumReleaseAge#181
Open
VictoriaBeilsten-Edmands wants to merge 1 commit into
Open
Upgrade to pnpm v10.20 & add minimumReleaseAge#181VictoriaBeilsten-Edmands wants to merge 1 commit into
VictoriaBeilsten-Edmands wants to merge 1 commit into
Conversation
VictoriaBeilsten-Edmands
force-pushed
the
vbe/pnpm-10.20
branch
from
b4af05e to
842bc24
Compare
akademy
reviewed
May 14, 2026
| "@jsonforms/material-renderers": "^3.7.0", | ||
| "@jsonforms/react": "^3.7.0", | ||
| "@mui/material": "^7.0.0", | ||
| "@mui/icons-material": "^7.0.0", |
Member
There was a problem hiding this comment.
We appear to have this both in dependencies and peerDependencies...
I was speaking to Guilherme about something related, and he said icons are fine under dependencies, as they (should) only include the icons we are using.
| }, | ||
| "dependencies": { | ||
| "@mui/icons-material": "^7.0.0", | ||
| "keycloak-js": "^26.2.1", |
Member
There was a problem hiding this comment.
Guilherme mentioned moving this to peer. I'm in two minds about it. Do you have an opinion?
(I'm asking under this MR, because I assume it's better to move it to peer so that it is easier to overwrite downstream?)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds minimumReleaseAge for dependencies.
Upgrades to pnpm v10.20 to allow minimumReleaseAge usage.
Adds override for fast-uri v3.1.2 due to npm security audit.
Added eslint/js to deps