Skip to content

[DOCS] Improve clarity of DBM self-hosted Postgres setup page#35912

Open
michaelperalta wants to merge 4 commits intomasterfrom
mike.peralta/dbm-postgres-selfhosted-clarity
Open

[DOCS] Improve clarity of DBM self-hosted Postgres setup page#35912
michaelperalta wants to merge 4 commits intomasterfrom
mike.peralta/dbm-postgres-selfhosted-clarity

Conversation

@michaelperalta
Copy link
Copy Markdown
Contributor

What does this PR do? What is the motivation?

Clarity improvements to the Database Monitoring setup page for self-hosted Postgres.

  • Split the postgresql.conf parameters table into Required and Optional sections
  • Added explicit ### Create the explain plan function heading (it was orphaned after version tabs, making it easy to miss)
  • Fixed the Postgres 9.6 "Verify" tab — it was identical to the ≥10 tab; the 9.6 tab now correctly uses the datadog.pg_stat_activity() and datadog.pg_stat_statements() function forms required for that version
  • Renamed verification sections for consistency: "Verify database permissions" (after Grant) and "Verify Agent setup" (after Install)
  • Simplified the dense "Grant the Agent access" intro paragraph
  • Fixed passive voice and removed Vale style violations
  • Consolidated duplicate reference links ([10] and [16] both pointed to the same restart URL)
  • Fixed title hyphenation: "Self-Hosted"

Merge instructions

Merge readiness:

  • Ready for merge

Additional notes

- Split config parameters table into Required/Optional sections
- Add explicit heading for explain plan function (was orphaned after version tabs)
- Fix 9.6 Verify tab to use function form (was identical to ≥10 tab)
- Rename sections for consistency: "Verify database permissions" and "Verify Agent setup"
- Simplify dense Grant intro paragraph
- Fix passive voice and remove style violations
- Consolidate duplicate reference links
- Fix title hyphenation: "Self-Hosted"

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@michaelperalta michaelperalta requested review from a team as code owners April 10, 2026 17:27
@github-actions
Copy link
Copy Markdown
Contributor

Preview links (active after the build_preview check completes)

Modified Files

@git-thuerk-done git-thuerk-done added the editorial review Waiting on a more in-depth review label Apr 10, 2026
@git-thuerk-done
Copy link
Copy Markdown
Contributor

git-thuerk-done commented Apr 10, 2026

Editorial review tracked in DOCS-13973 (batch review with PRs #35913, #35914, #35915, #35916, #35917, #35918).

Copy link
Copy Markdown
Contributor

@jeff-morgan-dd jeff-morgan-dd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR - just a couple of small style guide/grammar fixes here but approved otherwise!

### Collecting logs (optional)

PostgreSQL default logging is to `stderr`, and logs do not include detailed information. It is recommended to log into a file with additional details specified in the log line prefix. Refer to the PostgreSQL [documentation][11] on this topic for additional details.
PostgreSQL default logging is to `stderr`, and logs do not include detailed information. Log into a file with additional details specified in the log line prefix. See the PostgreSQL [documentation][11] for details.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
PostgreSQL default logging is to `stderr`, and logs do not include detailed information. Log into a file with additional details specified in the log line prefix. See the PostgreSQL [documentation][11] for details.
PostgreSQL default logging is to `stderr`, and logs do not include detailed information. Log in to a file with additional details specified in the log line prefix. See the PostgreSQL [documentation][11] for details.

To collect full `EXPLAIN ANALYZE` plans taken from all queries, you need to use [`auto_explain`][18], a first-party extension bundled with PostgreSQL available in all major providers. _Logging collection is a prerequisite to `auto_explain` collection_, so enable it before continuing.

<div class="alert alert-danger">
<strong>Important:</strong> <code>auto_explain</code> produces logs lines that may contain sensitive information from your application, similar to the raw values that appear in non-obfuscated SQL. You can use the <a href="/account_management/rbac/permissions/#database-monitoring"><code>dbm_parameterized_queries_read</code></a> permission to control who can see the resulting plans, but the log lines themselves <i>are</i> visible to all users within your Datadog org. Using <a href="/logs/guide/logs-rbac">RBAC for Logs</a> helps ensure these logs are only visible to the right users.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<strong>Important:</strong> <code>auto_explain</code> produces logs lines that may contain sensitive information from your application, similar to the raw values that appear in non-obfuscated SQL. You can use the <a href="/account_management/rbac/permissions/#database-monitoring"><code>dbm_parameterized_queries_read</code></a> permission to control who can see the resulting plans, but the log lines themselves <i>are</i> visible to all users within your Datadog org. Using <a href="/logs/guide/logs-rbac">RBAC for Logs</a> helps ensure these logs are only visible to the right users.
<strong>Important:</strong> <code>auto_explain</code> produces log lines that may contain sensitive information from your application, similar to the raw values that appear in non-obfuscated SQL. You can use the <a href="/account_management/rbac/permissions/#database-monitoring"><code>dbm_parameterized_queries_read</code></a> permission to control who can see the resulting plans, but the log lines themselves <i>are</i> visible to all users within your Datadog org. Using <a href="/logs/guide/logs-rbac">RBAC for Logs</a> helps ensure these logs are only visible to the right users.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not part of the PR, but small fix since this is a cleanup effort.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

editorial review Waiting on a more in-depth review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants