Skip to content

Log profiler flare messages at WARN level #10444

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jbachorik merged 1 commit into from
Jan 26, 2026
Merged

Log profiler flare messages at WARN level #10444

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions internal-api/src/main/java/datadog/trace/api/profiling/ProfilerFlareLogger.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,10 +7,14 @@
import java.util.ArrayList;
import java.util.List;
import java.util.zip.ZipOutputStream;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
import org.slf4j.helpers.FormattingTuple;
import org.slf4j.helpers.MessageFormatter;

public final class ProfilerFlareLogger implements TracerFlare.Reporter {
private static final Logger log = LoggerFactory.getLogger(ProfilerFlareLogger.class);

private static final class Singleton {
private static final ProfilerFlareLogger INSTANCE = new ProfilerFlareLogger();
}
Expand All @@ -36,6 +40,9 @@ public static ProfilerFlareLogger getInstance() {
* @return Returns {@literal true} if the message was stored for flare, {@literal false} otherwise
*/
public boolean log(String msgFormat, Object... args) {
// if something is important enough to store in flare, perhaps logging at WARN level is fine
log.warn(msgFormat, args);

FormattingTuple ft = MessageFormatter.arrayFormat(msgFormat, args);
StringBuilder sb =
new StringBuilder(Instant.now().atZone(ZoneOffset.UTC).toString())
Expand Down
Loading