-
Notifications
You must be signed in to change notification settings - Fork 324
Log profiler flare messages at WARN level #10444
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 62 metrics, 9 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.59.0-SNAPSHOT~63ce2a4dd3, baseline=1.59.0-SNAPSHOT~b3c7600a42
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.086 s) : 0, 1085915
Total [baseline] (8.716 s) : 0, 8715545
Agent [candidate] (1.088 s) : 0, 1087999
Total [candidate] (8.72 s) : 0, 8719923
section iast
Agent [baseline] (1.235 s) : 0, 1235015
Total [baseline] (9.322 s) : 0, 9321940
Agent [candidate] (1.229 s) : 0, 1229185
Total [candidate] (9.365 s) : 0, 9364727
gantt
title insecure-bank - break down per module: candidate=1.59.0-SNAPSHOT~63ce2a4dd3, baseline=1.59.0-SNAPSHOT~b3c7600a42
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.17 ms) : 0, 1170
crashtracking [candidate] (1.188 ms) : 0, 1188
BytebuddyAgent [baseline] (650.939 ms) : 0, 650939
BytebuddyAgent [candidate] (652.116 ms) : 0, 652116
AgentMeter [baseline] (28.735 ms) : 0, 28735
AgentMeter [candidate] (28.837 ms) : 0, 28837
GlobalTracer [baseline] (256.616 ms) : 0, 256616
GlobalTracer [candidate] (257.492 ms) : 0, 257492
AppSec [baseline] (32.672 ms) : 0, 32672
AppSec [candidate] (32.827 ms) : 0, 32827
Debugger [baseline] (65.654 ms) : 0, 65654
Debugger [candidate] (66.115 ms) : 0, 66115
Remote Config [baseline] (608.789 µs) : 0, 609
Remote Config [candidate] (616.602 µs) : 0, 617
Telemetry [baseline] (9.608 ms) : 0, 9608
Telemetry [candidate] (8.863 ms) : 0, 8863
Flare Poller [baseline] (4.504 ms) : 0, 4504
Flare Poller [candidate] (4.48 ms) : 0, 4480
section iast
crashtracking [baseline] (1.185 ms) : 0, 1185
crashtracking [candidate] (1.177 ms) : 0, 1177
BytebuddyAgent [baseline] (798.425 ms) : 0, 798425
BytebuddyAgent [candidate] (792.453 ms) : 0, 792453
AgentMeter [baseline] (11.361 ms) : 0, 11361
AgentMeter [candidate] (11.31 ms) : 0, 11310
GlobalTracer [baseline] (249.648 ms) : 0, 249648
GlobalTracer [candidate] (248.619 ms) : 0, 248619
IAST [baseline] (27.149 ms) : 0, 27149
IAST [candidate] (26.845 ms) : 0, 26845
AppSec [baseline] (32.667 ms) : 0, 32667
AppSec [candidate] (33.827 ms) : 0, 33827
Debugger [baseline] (66.8 ms) : 0, 66800
Debugger [candidate] (66.92 ms) : 0, 66920
Remote Config [baseline] (525.263 µs) : 0, 525
Remote Config [candidate] (547.149 µs) : 0, 547
Telemetry [baseline] (8.43 ms) : 0, 8430
Telemetry [candidate] (8.648 ms) : 0, 8648
Flare Poller [baseline] (3.499 ms) : 0, 3499
Flare Poller [candidate] (3.602 ms) : 0, 3602
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.59.0-SNAPSHOT~63ce2a4dd3, baseline=1.59.0-SNAPSHOT~b3c7600a42
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.094 s) : 0, 1094461
Total [baseline] (10.71 s) : 0, 10709962
Agent [candidate] (1.088 s) : 0, 1087579
Total [candidate] (10.713 s) : 0, 10712748
section appsec
Agent [baseline] (1.275 s) : 0, 1274869
Total [baseline] (11.104 s) : 0, 11103821
Agent [candidate] (1.27 s) : 0, 1269819
Total [candidate] (10.893 s) : 0, 10892872
section iast
Agent [baseline] (1.242 s) : 0, 1241592
Total [baseline] (11.164 s) : 0, 11164031
Agent [candidate] (1.23 s) : 0, 1229867
Total [candidate] (11.018 s) : 0, 11018098
section profiling
Agent [baseline] (1.206 s) : 0, 1206114
Total [baseline] (10.848 s) : 0, 10848471
Agent [candidate] (1.207 s) : 0, 1206763
Total [candidate] (10.865 s) : 0, 10865160
gantt
title petclinic - break down per module: candidate=1.59.0-SNAPSHOT~63ce2a4dd3, baseline=1.59.0-SNAPSHOT~b3c7600a42
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.18 ms) : 0, 1180
crashtracking [candidate] (1.17 ms) : 0, 1170
BytebuddyAgent [baseline] (655.213 ms) : 0, 655213
BytebuddyAgent [candidate] (650.583 ms) : 0, 650583
AgentMeter [baseline] (29.144 ms) : 0, 29144
AgentMeter [candidate] (28.777 ms) : 0, 28777
GlobalTracer [baseline] (258.613 ms) : 0, 258613
GlobalTracer [candidate] (257.518 ms) : 0, 257518
AppSec [baseline] (33.167 ms) : 0, 33167
AppSec [candidate] (32.925 ms) : 0, 32925
Debugger [baseline] (68.32 ms) : 0, 68320
Debugger [candidate] (67.108 ms) : 0, 67108
Remote Config [baseline] (606.4 µs) : 0, 606
Remote Config [candidate] (611.477 µs) : 0, 611
Telemetry [baseline] (8.906 ms) : 0, 8906
Telemetry [candidate] (8.964 ms) : 0, 8964
Flare Poller [baseline] (3.761 ms) : 0, 3761
Flare Poller [candidate] (4.543 ms) : 0, 4543
section appsec
crashtracking [baseline] (1.177 ms) : 0, 1177
crashtracking [candidate] (1.179 ms) : 0, 1179
BytebuddyAgent [baseline] (692.132 ms) : 0, 692132
BytebuddyAgent [candidate] (691.079 ms) : 0, 691079
AgentMeter [baseline] (12.107 ms) : 0, 12107
AgentMeter [candidate] (12.018 ms) : 0, 12018
GlobalTracer [baseline] (251.953 ms) : 0, 251953
GlobalTracer [candidate] (250.563 ms) : 0, 250563
AppSec [baseline] (174.613 ms) : 0, 174613
AppSec [candidate] (173.209 ms) : 0, 173209
Debugger [baseline] (68.488 ms) : 0, 68488
Debugger [candidate] (67.885 ms) : 0, 67885
Remote Config [baseline] (708.11 µs) : 0, 708
Remote Config [candidate] (685.346 µs) : 0, 685
Telemetry [baseline] (9.394 ms) : 0, 9394
Telemetry [candidate] (9.326 ms) : 0, 9326
Flare Poller [baseline] (3.703 ms) : 0, 3703
Flare Poller [candidate] (3.595 ms) : 0, 3595
IAST [baseline] (25.126 ms) : 0, 25126
IAST [candidate] (24.723 ms) : 0, 24723
section iast
crashtracking [baseline] (1.209 ms) : 0, 1209
crashtracking [candidate] (1.169 ms) : 0, 1169
BytebuddyAgent [baseline] (801.506 ms) : 0, 801506
BytebuddyAgent [candidate] (793.06 ms) : 0, 793060
AgentMeter [baseline] (11.577 ms) : 0, 11577
AgentMeter [candidate] (11.298 ms) : 0, 11298
GlobalTracer [baseline] (251.146 ms) : 0, 251146
GlobalTracer [candidate] (248.922 ms) : 0, 248922
AppSec [baseline] (35.063 ms) : 0, 35063
AppSec [candidate] (31.042 ms) : 0, 31042
Debugger [baseline] (65.595 ms) : 0, 65595
Debugger [candidate] (69.758 ms) : 0, 69758
Remote Config [baseline] (541.733 µs) : 0, 542
Remote Config [candidate] (527.376 µs) : 0, 527
Telemetry [baseline] (8.607 ms) : 0, 8607
Telemetry [candidate] (8.427 ms) : 0, 8427
Flare Poller [baseline] (3.527 ms) : 0, 3527
Flare Poller [candidate] (3.484 ms) : 0, 3484
IAST [baseline] (27.464 ms) : 0, 27464
IAST [candidate] (26.908 ms) : 0, 26908
section profiling
ProfilingAgent [baseline] (96.297 ms) : 0, 96297
ProfilingAgent [candidate] (96.29 ms) : 0, 96290
crashtracking [baseline] (1.212 ms) : 0, 1212
crashtracking [candidate] (1.207 ms) : 0, 1207
BytebuddyAgent [baseline] (700.423 ms) : 0, 700423
BytebuddyAgent [candidate] (700.398 ms) : 0, 700398
AgentMeter [baseline] (8.853 ms) : 0, 8853
AgentMeter [candidate] (8.853 ms) : 0, 8853
GlobalTracer [baseline] (215.776 ms) : 0, 215776
GlobalTracer [candidate] (215.688 ms) : 0, 215688
AppSec [baseline] (32.448 ms) : 0, 32448
AppSec [candidate] (32.436 ms) : 0, 32436
Debugger [baseline] (67.715 ms) : 0, 67715
Debugger [candidate] (68.056 ms) : 0, 68056
Remote Config [baseline] (605.313 µs) : 0, 605
Remote Config [candidate] (600.162 µs) : 0, 600
Telemetry [baseline] (8.789 ms) : 0, 8789
Telemetry [candidate] (8.64 ms) : 0, 8640
Flare Poller [baseline] (4.221 ms) : 0, 4221
Flare Poller [candidate] (4.825 ms) : 0, 4825
Profiling [baseline] (96.864 ms) : 0, 96864
Profiling [candidate] (96.869 ms) : 0, 96869
LoadParameters
See matching parameters
SummaryFound 4 performance improvements and 1 performance regressions! Performance is the same for 15 metrics, 16 unstable metrics.
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.59.0-SNAPSHOT~63ce2a4dd3, baseline=1.59.0-SNAPSHOT~b3c7600a42
dateFormat X
axisFormat %s
section baseline
no_agent (17.926 ms) : 17742, 18109
. : milestone, 17926,
appsec (19.262 ms) : 19066, 19458
. : milestone, 19262,
code_origins (17.659 ms) : 17483, 17835
. : milestone, 17659,
iast (17.879 ms) : 17703, 18056
. : milestone, 17879,
profiling (18.855 ms) : 18665, 19045
. : milestone, 18855,
tracing (17.551 ms) : 17378, 17723
. : milestone, 17551,
section candidate
no_agent (18.106 ms) : 17918, 18293
. : milestone, 18106,
appsec (18.4 ms) : 18217, 18584
. : milestone, 18400,
code_origins (17.884 ms) : 17706, 18063
. : milestone, 17884,
iast (17.558 ms) : 17385, 17732
. : milestone, 17558,
profiling (20.042 ms) : 19840, 20243
. : milestone, 20042,
tracing (17.601 ms) : 17426, 17776
. : milestone, 17601,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.59.0-SNAPSHOT~63ce2a4dd3, baseline=1.59.0-SNAPSHOT~b3c7600a42
dateFormat X
axisFormat %s
section baseline
no_agent (1.173 ms) : 1161, 1185
. : milestone, 1173,
iast (3.156 ms) : 3120, 3192
. : milestone, 3156,
iast_FULL (5.869 ms) : 5811, 5927
. : milestone, 5869,
iast_GLOBAL (3.595 ms) : 3546, 3644
. : milestone, 3595,
profiling (2.037 ms) : 2019, 2056
. : milestone, 2037,
tracing (1.761 ms) : 1747, 1774
. : milestone, 1761,
section candidate
no_agent (1.25 ms) : 1238, 1262
. : milestone, 1250,
iast (3.086 ms) : 3044, 3129
. : milestone, 3086,
iast_FULL (5.518 ms) : 5464, 5572
. : milestone, 5518,
iast_GLOBAL (3.602 ms) : 3553, 3652
. : milestone, 3602,
profiling (1.997 ms) : 1980, 2014
. : milestone, 1997,
tracing (1.773 ms) : 1759, 1788
. : milestone, 1773,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.59.0-SNAPSHOT~63ce2a4dd3, baseline=1.59.0-SNAPSHOT~b3c7600a42
dateFormat X
axisFormat %s
section baseline
no_agent (15.59 s) : 15590000, 15590000
. : milestone, 15590000,
appsec (14.61 s) : 14610000, 14610000
. : milestone, 14610000,
iast (18.219 s) : 18219000, 18219000
. : milestone, 18219000,
iast_GLOBAL (17.818 s) : 17818000, 17818000
. : milestone, 17818000,
profiling (15.47 s) : 15470000, 15470000
. : milestone, 15470000,
tracing (14.611 s) : 14611000, 14611000
. : milestone, 14611000,
section candidate
no_agent (15.53 s) : 15530000, 15530000
. : milestone, 15530000,
appsec (15.048 s) : 15048000, 15048000
. : milestone, 15048000,
iast (18.83 s) : 18830000, 18830000
. : milestone, 18830000,
iast_GLOBAL (17.931 s) : 17931000, 17931000
. : milestone, 17931000,
profiling (15.008 s) : 15008000, 15008000
. : milestone, 15008000,
tracing (14.611 s) : 14611000, 14611000
. : milestone, 14611000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.59.0-SNAPSHOT~63ce2a4dd3, baseline=1.59.0-SNAPSHOT~b3c7600a42
dateFormat X
axisFormat %s
section baseline
no_agent (1.474 ms) : 1463, 1486
. : milestone, 1474,
appsec (3.676 ms) : 3458, 3894
. : milestone, 3676,
iast (2.215 ms) : 2150, 2280
. : milestone, 2215,
iast_GLOBAL (2.261 ms) : 2195, 2326
. : milestone, 2261,
profiling (2.076 ms) : 2021, 2130
. : milestone, 2076,
tracing (2.044 ms) : 1992, 2096
. : milestone, 2044,
section candidate
no_agent (1.473 ms) : 1462, 1485
. : milestone, 1473,
appsec (3.71 ms) : 3489, 3931
. : milestone, 3710,
iast (2.207 ms) : 2142, 2273
. : milestone, 2207,
iast_GLOBAL (2.257 ms) : 2191, 2322
. : milestone, 2257,
profiling (2.07 ms) : 2017, 2123
. : milestone, 2070,
tracing (2.034 ms) : 1983, 2086
. : milestone, 2034,
|
rkennke
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok
What Does This Do
Logs profiler flare messages at WARN level in addition to storing them for the flare report. This ensures important profiler diagnostic messages are visible in application logs.
Motivation
Messages logged via
ProfilerFlareLoggerare important enough to be included in flare reports, which means they likely indicate issues worth investigating. By also logging them at WARN level, operators can see these messages in real-time without waiting for a flare to be generated.Additional Notes
N/A
Contributor Checklist
type:and (comp:orinst:) labels in addition to any useful labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROF-13551]