-
Notifications
You must be signed in to change notification settings - Fork 129
[AGENTONB-2593] DDOT gateway with interface component #2276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
songy23
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A high-level question: where are Services defined in operator? In DDOT Gateway we need to create a k8s Service to expose the gateway pods: https://github.com/DataDog/helm-charts/blob/main/charts/datadog/templates/agent-services.yaml#L119
This is done within the ╰─❯ k describe svc datadog-agent-otel-collector-gateway
Name: datadog-agent-otel-collector-gateway
Namespace: system
Labels: app.kubernetes.io/instance=datadog-agent
app.kubernetes.io/managed-by=datadog-operator
app.kubernetes.io/name=datadog-agent-deployment
app.kubernetes.io/part-of=system-datadog--agent
app.kubernetes.io/version=
operator.datadoghq.com/managed-by-store=true
Annotations: <none>
Selector: agent.datadoghq.com/component=otel-collector-gateway,app.kubernetes.io/part-of=system-datadog--agent
Type: ClusterIP
IP Family Policy: SingleStack
IP Families: IPv4
IP: 10.96.102.42
IPs: 10.96.102.42
Port: otlpgrpcport 4317/TCP
TargetPort: 4317/TCP
Endpoints: 10.244.1.10:4317
Port: otlphttpport 4318/TCP
TargetPort: 4318/TCP
Endpoints: 10.244.1.10:4318
Session Affinity: None
Internal Traffic Policy: Local
Events: <none> |
songy23
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good so far, just a few naming suggestions
7f1efb8 to
ed3e0fb
Compare
2b17956 to
cd9ca08
Compare
What does this PR do?
Start implementing DDOT gateway interfaces using the componentreconciler
Note the actual gateway feature, RBAC, HPA etc. are not yet implemented in this PR and will be in follow-up PRs.
Motivation
Working towards DDOT gateway support in operator
Additional Notes
No QA needed for now since this PR only adds the interfaces but no implementations.
Minimum Agent Versions
Are there minimum versions of the Datadog Agent and/or Cluster Agent required?
Describe your test plan
Write there any instructions and details you may have to test your PR.
Checklist
bug,enhancement,refactoring,documentation,tooling, and/ordependenciesqa/skip-qalabel