Skip to content

Conversation

@songy23
Copy link
Member

@songy23 songy23 commented Nov 14, 2025

What does this PR do?

Add ManageOtelAgentGateway to Feature interface. For now no features do anything concrete on otel agent gateway.

Motivation

Boilerplate code split from #2276 since #2276 is too large and is blocked by #2247

Checklist

  • PR has at least one valid label: bug, enhancement, refactoring, documentation, tooling, and/or dependencies
  • PR has a milestone or the qa/skip-qa label

@songy23 songy23 added this to the v1.22.0 milestone Nov 14, 2025
@songy23 songy23 added enhancement New feature or request qa/skip-qa labels Nov 14, 2025
@codecov-commenter
Copy link

codecov-commenter commented Nov 14, 2025

Codecov Report

❌ Patch coverage is 0% with 67 lines in your changes missing coverage. Please review.
✅ Project coverage is 37.80%. Comparing base (24f1c33) to head (82a7dac).

Files with missing lines Patch % Lines
internal/controller/datadogagent/feature/types.go 0.00% 3 Missing ⚠️
...atadogagent/feature/admissioncontroller/feature.go 0.00% 2 Missing ⚠️
...nal/controller/datadogagent/feature/apm/feature.go 0.00% 2 Missing ⚠️
...nal/controller/datadogagent/feature/asm/feature.go 0.00% 2 Missing ⚠️
...roller/datadogagent/feature/autoscaling/feature.go 0.00% 2 Missing ⚠️
...ller/datadogagent/feature/clusterchecks/feature.go 0.00% 2 Missing ⚠️
...dogagent/feature/controlplanemonitoring/feature.go 0.00% 2 Missing ⚠️
...al/controller/datadogagent/feature/cspm/feature.go 0.00% 2 Missing ⚠️
...nal/controller/datadogagent/feature/cws/feature.go 0.00% 2 Missing ⚠️
...ntroller/datadogagent/feature/dogstatsd/feature.go 0.00% 2 Missing ⚠️
... and 23 more
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2315      +/-   ##
==========================================
- Coverage   37.91%   37.80%   -0.12%     
==========================================
  Files         258      258              
  Lines       21813    21878      +65     
==========================================
  Hits         8271     8271              
- Misses      12908    12973      +65     
  Partials      634      634              
Flag Coverage Δ
unittests 37.80% <0.00%> (-0.12%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...atadogagent/feature/admissioncontroller/feature.go 66.06% <0.00%> (-0.49%) ⬇️
...nal/controller/datadogagent/feature/apm/feature.go 68.85% <0.00%> (-0.48%) ⬇️
...nal/controller/datadogagent/feature/asm/feature.go 72.41% <0.00%> (-2.59%) ⬇️
...roller/datadogagent/feature/autoscaling/feature.go 82.14% <0.00%> (-3.05%) ⬇️
...ller/datadogagent/feature/clusterchecks/feature.go 66.45% <0.00%> (-0.87%) ⬇️
...dogagent/feature/controlplanemonitoring/feature.go 14.07% <0.00%> (-0.15%) ⬇️
...al/controller/datadogagent/feature/cspm/feature.go 74.57% <0.00%> (-0.86%) ⬇️
...nal/controller/datadogagent/feature/cws/feature.go 78.07% <0.00%> (-0.85%) ⬇️
...ntroller/datadogagent/feature/dogstatsd/feature.go 68.87% <0.00%> (-0.93%) ⬇️
...l/controller/datadogagent/feature/dummy/feature.go 0.00% <0.00%> (ø)
... and 23 more

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 24f1c33...82a7dac. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@songy23 songy23 marked this pull request as ready for review November 17, 2025 16:23
@songy23 songy23 requested review from a team as code owners November 17, 2025 16:23
@songy23
Copy link
Member Author

songy23 commented Nov 17, 2025

e2e test failures are unrelated, they also fail in mainline: http://gitlab.ddbuild.io/DataDog/datadog-operator/-/jobs/1238451465

Copy link
Contributor

@gabedos gabedos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@songy23 songy23 merged commit 0e9e931 into main Nov 17, 2025
26 of 31 checks passed
@songy23 songy23 deleted the yang.song/OTAGENT-512-2 branch November 17, 2025 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request qa/skip-qa

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants