Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion Sprint-3/2-practice-tdd/count.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,11 @@
function countChar(stringOfCharacters, findCharacter) {
return 5
let total = 0;
for (const char of stringOfCharacters) {
if (char === findCharacter) {
total += 1;
}
}
return total;
}

module.exports = countChar;
42 changes: 42 additions & 0 deletions Sprint-3/2-practice-tdd/count.test.js
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Could consider testing more samples.

  • Could consider testing these cases:

    • A case to show that the match is case sensitive
    • A case to show that the function is expected to work also for non-alphabets

Original file line number Diff line number Diff line change
Expand Up @@ -22,3 +22,45 @@ test("should count multiple occurrences of a character", () => {
// And a character `char` that does not exist within `str`.
// When the function is called with these inputs,
// Then it should return 0, indicating that no occurrences of `char` were found.
test("should count zero occurrences of a character", () => {
const str = "aaaaa";
const char = "b";
const count = countChar(str, char);
expect(count).toEqual(0);
});

// Scenario: Non-consecutive occurrances
// Given the input string `str`,
// And a character `char` that appears in more than one block within `str`.
// When the function is called with these inputs,
// Then it should return the number of total occurrances.
test("should count non-contiguous occurrences of a character", () => {
const str = "aaaaabba";
const char = "a";
const count = countChar(str, char);
expect(count).toEqual(6);
});

// Scenario: Same character in upper and lower case.
// Given the input string 'str'
// And a character 'char' that apears in both lower case and upper case.
// When the function is called with these inputs,
// Then it should only count when the cases match
test("should be case sensitive", () => {
const str = "Hello, how are you";
const char = "H";
const count = countChar(str, char);
expect(count).toEqual(1);
});

// Scenario: Non-alphabetical chars in the string.
// Given the input string 'str'
// And a character 'char' that is not in the alphabet
// When the function is called with these inputs,
// Then it should match as usual
test("should match non-alphabetical chars", () => {
const str = "Incredible news! We've joined Code Your Future!";
const char = "!";
const count = countChar(str, char);
expect(count).toEqual(2);
});
18 changes: 17 additions & 1 deletion Sprint-3/2-practice-tdd/get-ordinal-number.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,21 @@
function getOrdinalNumber(num) {
return "1st";
const lastTwoDigits = num % 100;

if (lastTwoDigits >= 11 && lastTwoDigits <= 13) {
return String(num) + "th";
}

const lastDigit = num % 10;
switch (lastDigit) {
case 1:
return String(num) + "st";
case 2:
return String(num) + "nd";
case 3:
return String(num) + "rd";
default:
return String(num) + "th";
}
}

module.exports = getOrdinalNumber;
47 changes: 47 additions & 0 deletions Sprint-3/2-practice-tdd/get-ordinal-number.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -18,3 +18,50 @@ test("should append 'st' for numbers ending with 1, except those ending with 11"
expect(getOrdinalNumber(21)).toEqual("21st");
expect(getOrdinalNumber(131)).toEqual("131st");
});

// Case 2: Numbers ending with 2, except those ending with 12
// When the number ends with 2
// Then the function should return a string by appending "nd" to the number.
test("should append 'nd' for numbers ending with 2", () => {
expect(getOrdinalNumber(2)).toEqual("2nd");
expect(getOrdinalNumber(22)).toEqual("22nd");
expect(getOrdinalNumber(132)).toEqual("132nd");
});

// Case 3: Numbers ending with 3, except those ending in 13
// When the number ends with 3
// Then the function should return a string by appending "rd" to the number.
test("should append 'rd' for numbers ending with 3", () => {
expect(getOrdinalNumber(3)).toEqual("3rd");
expect(getOrdinalNumber(23)).toEqual("23rd");
expect(getOrdinalNumber(223)).toEqual("223rd");
});

// Case 4: the general case
// When numbers end with 0, 4, 5, 6, 7, 8, 9
// The function should return a string by appending "th" to the number
test("should append 'th' for numbers ending with 0, 4, 5, 6, 7, 8, 9", () => {
expect(getOrdinalNumber(10)).toEqual("10th");
expect(getOrdinalNumber(24)).toEqual("24th");
expect(getOrdinalNumber(25)).toEqual("25th");
expect(getOrdinalNumber(46)).toEqual("46th");
expect(getOrdinalNumber(57)).toEqual("57th");
expect(getOrdinalNumber(78)).toEqual("78th");
expect(getOrdinalNumber(89)).toEqual("89th");
expect(getOrdinalNumber(189)).toEqual("189th");
});

// Case 5: The special cases when last two digits are 11, 12 13
// When the last two digits are 11, 12, or 13
// Then the function should return a string by appending "th" to the number.
test("should append 'th' for number whose last two digits are 11, 12, 13", () => {
expect(getOrdinalNumber(11)).toEqual("11th");
expect(getOrdinalNumber(12)).toEqual("12th");
expect(getOrdinalNumber(13)).toEqual("13th");
expect(getOrdinalNumber(111)).toEqual("111th");
expect(getOrdinalNumber(112)).toEqual("112th");
expect(getOrdinalNumber(113)).toEqual("113th");
expect(getOrdinalNumber(211)).toEqual("211th");
expect(getOrdinalNumber(212)).toEqual("212th");
expect(getOrdinalNumber(313)).toEqual("313th");
});
4 changes: 2 additions & 2 deletions Sprint-3/2-practice-tdd/repeat-str.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
function repeatStr() {
return "hellohellohello";
function repeatStr(str, count) {
return str.repeat(count);
}

module.exports = repeatStr;
20 changes: 18 additions & 2 deletions Sprint-3/2-practice-tdd/repeat-str.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,7 @@ const repeatStr = require("./repeat-str");
// Given a target string `str` and a positive integer `count` greater than 1,
// When the repeatStr function is called with these inputs,
// Then it should return a string that contains the original `str` repeated `count` times.

test("should repeat the string count times", () => {
test("should repeat the string 3 times", () => {
const str = "hello";
const count = 3;
const repeatedStr = repeatStr(str, count);
Expand All @@ -20,13 +19,30 @@ test("should repeat the string count times", () => {
// Given a target string `str` and a `count` equal to 1,
// When the repeatStr function is called with these inputs,
// Then it should return the original `str` without repetition.
test("should not repeat string with a count of 1", () => {
const str = "hello";
const count = 1;
const repeatedStr = repeatStr(str, count);
expect(repeatedStr).toEqual("hello");
});

// Case: Handle count of 0:
// Given a target string `str` and a `count` equal to 0,
// When the repeatStr function is called with these inputs,
// Then it should return an empty string.
test("should return empty string with a count of 0", () => {
const str = "hello";
const count = 0;
const repeatedStr = repeatStr(str, count);
expect(repeatedStr).toEqual("");
});

// Case: Handle negative count:
// Given a target string `str` and a negative integer `count`,
// When the repeatStr function is called with these inputs,
// Then it should throw an error, as negative counts are not valid.
test("show error message when count < 0", () => {
const str = "hello";
const count = -2;
expect(() => repeatStr(str, count)).toThrow();
});