London | 26-ITP-January | Raihan Sharif | Sprint 3 | Coursework/sprint3/2-practice-tdd#1056
Open
RaihanSharif wants to merge 4 commits intoCodeYourFuture:mainfrom
Open
London | 26-ITP-January | Raihan Sharif | Sprint 3 | Coursework/sprint3/2-practice-tdd#1056RaihanSharif wants to merge 4 commits intoCodeYourFuture:mainfrom
RaihanSharif wants to merge 4 commits intoCodeYourFuture:mainfrom
Conversation
RaihanSharif
added
the
Needs Review
cjyuan
reviewed
Mar 6, 2026
Contributor
There was a problem hiding this comment.
-
Could consider testing more samples.
-
Could consider testing these cases:
- A case to show that the match is case sensitive
- A case to show that the function is expected to work also for non-alphabets
Comment on lines
+2
to
+5
| // 11 is a special case | ||
| if (num === 11) { | ||
| return "11th"; | ||
| } |
Contributor
There was a problem hiding this comment.
11 is not the only special case. Can you look up the rules of ordinal numbers and update also the tests?
| } | ||
|
|
||
| if ((count) => 1) { | ||
| return str.repeat(count); |
Contributor
There was a problem hiding this comment.
Can you look up the behavior of .repeat(count) when count is 0 or negative?
cjyuan
added
Reviewed
str.repeat() throws Error for values < 0 and return "" for value of -0. Which covers all cases.
Author
|
Made all changes mentioned in review. |
Contributor
|
Changes look good. Note: If your PR is ready to be re-reviewed, you should also add the "Needs Review" label. |
cjyuan
added
Complete
Author
Will do. Thank you for the review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
Added necessary implentations and tests