Skip to content

fix: Update GitHub status message to match state from comment_pr() #975

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cfsmp3 merged 1 commit into from
Dec 25, 2025
Merged

fix: Update GitHub status message to match state from comment_pr() #975

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions mod_ci/controllers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1890,6 +1890,13 @@ def progress_type_request(log, test, test_id, request) -> bool:
message = 'Tests completed'
if test.test_type == TestType.pull_request:
state = comment_pr(test)
# Update message to match the state returned by comment_pr()
# comment_pr() uses different logic: it returns SUCCESS if there are
# no NEW failures compared to master (pre-existing failures are OK)
if state == Status.SUCCESS:
message = 'All tests passed'
else:
message = 'Not all tests completed successfully, please check'
update_build_badge(state, test)

else:
Expand Down