fix: Update GitHub status message to match state from comment_pr() #975
+7
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.



Summary
comment_pr()returns a different state than the initial crash/results check, the message is now updated to matchProblem
When a PR's tests complete, the code:
comment_pr()which returns a potentially different state (SUCCESS if no new failures compared to master)This caused confusing situations like test 7203 where:
Root Cause
The
comment_pr()function uses different logic - it returns SUCCESS if there are no new failures compared to master (pre-existing failures are OK). The initial check was finding some hash mismatches, but those were pre-existing on master.Solution
Update the message after
comment_pr()returns to match the new state:Test plan
test_comments_successfully_in_passed_pr_test,test_comments_successfuly_in_failed_pr_test)🤖 Generated with Claude Code