Fix Windows CI tests not running after artifact rename#1029
Merged
Conversation
CCExtractor/ccextractor#2119 renamed the Windows build artifact from "CCExtractor Windows Release build" to "CCExtractor Windows x64 Release build" (adding x86 as a separate artifact). The exact-match lookup in find_artifact_for_commit() could no longer find it, so verify_artifacts_exist() returned False for Windows, causing all Windows tests to be skipped with "Not ran - no code changes". Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
cfsmp3
requested review from
canihavesomecoffee and
thealphadollar
as code owners
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
"CCExtractor Windows Release build"to"CCExtractor Windows x64 Release build"(with a newx86artifact alongside it).find_artifact_for_commit()does an exact string match againstArtifact_names.windows, so the lookup failed,verify_artifacts_exist()returnedFalse, and all Windows tests were skipped with "Not ran - no code changes".Test plan
.cfile changes triggers Windows CI tests🤖 Generated with Claude Code