-
Notifications
You must be signed in to change notification settings - Fork 297
Checkin sample DAB deployment scripts #3022
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
/azp run |
|
Azure Pipelines could not run because the pipeline triggers exclude this branch/path. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR adds comprehensive PowerShell deployment scripts for Data API Builder (DAB) to Azure, streamlining the end-to-end deployment process for both Azure Container Apps and Azure Container Instances. The scripts automate infrastructure setup, database provisioning, test data loading, and DAB configuration generation.
- Added two fully automated PowerShell starter scripts for quick Azure deployment
- Scripts handle complete infrastructure setup including ACR, SQL Server, and container deployment
- Enhanced documentation with detailed usage examples, troubleshooting, and comparison tables
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 17 comments.
| File | Description |
|---|---|
| samples/azure/readme.md | Comprehensive documentation update with quick start guides, parameter descriptions, examples, troubleshooting, and service comparison tables |
| samples/azure/azure-container-apps-dab-starter.ps1 | New automated deployment script for Azure Container Apps with auto-scaling, HTTPS, and managed environment support |
| samples/azure/azure-container-instances-dab-starter.ps1 | New automated deployment script for Azure Container Instances with simpler single-instance architecture for dev/test scenarios |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…ation file handling
… memory configuration, and update README with usage examples and features.
Aniruddh25
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Posting comments for the review so far - done upto autogeneration of resource prefix in the aca script
…ptions, and updated README with usage examples for better clarity and usability.
…Azure/data-api-builder into Usr/sogh/dabsampledeployscripts
Aniruddh25
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving since this is sample only. Consider the suggestions in a followup.
…eneration logic for clarity
…Azure/data-api-builder into Usr/sogh/dabsampledeployscripts
|
/azp run |
|
Azure Pipelines could not run because the pipeline triggers exclude this branch/path. |
|
/azp run |
|
Azure Pipelines could not run because the pipeline triggers exclude this branch/path. |
Summary
Adds automated PowerShell scripts for deploying Data API builder to Azure Container Apps (ACA) and Azure Container Instances (ACI) with complete infrastructure setup.
Closes: - #3001
Changes
New sample scripts
azure-container-apps-dab-starter.ps1- Deploy to Azure Container Appsazure-container-instances-dab-starter.ps1- Deploy to Azure Container InstancesFeatures
DatabaseSchema-MsSql.sqlUsage
Azure Container Apps (ACA)
Basic configuration
Higher configuration
Azure Container Instances (ACI)
Basic configuration
Higher configuration