Skip to content

chore: defensive asserts for map/vector retrievals and optional values in cpp #19439

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fcarreiro merged 1 commit into from
Jan 8, 2026
Merged

chore: defensive asserts for map/vector retrievals and optional values in cpp #19439

fcarreiro merged 1 commit into from
Jan 8, 2026

Conversation

@dbanks12
Copy link
Contributor

@dbanks12 dbanks12 commented Jan 8, 2026 •
edited
Loading

To prevent crashes in worst-case scenarios

@dbanks12 Graphite App
Copy link
Contributor Author

dbanks12 commented Jan 8, 2026

This stack of pull requests is managed by Graphite. Learn more about stacking.

@dbanks12 dbanks12 marked this pull request as ready for review January 8, 2026 18:54
@dbanks12 dbanks12 changed the title chore: defensive asserts for map retrievals in cpp chore: defensive asserts for map/vector retrievals and optional values in cpp Jan 8, 2026
@AztecBot
Copy link
Collaborator

AztecBot commented Jan 8, 2026

Flakey Tests

🤖 says: This CI run detected 1 tests that failed, but were tolerated due to a .test_patterns.yml entry.

\033FLAKED\033 (\0338;;http://ci.aztec-labs.com/6f779aa80000e083�6f779aa80000e0838;;�\033):  yarn-project/end-to-end/scripts/run_test.sh simple src/e2e_p2p/add_rollup.test.ts (601s) (code: 124) group:e2e-p2p-epoch-flakes (\033dbanks12\033: chore: defensive asserts for map retrievals in cpp)

@fcarreiro fcarreiro merged commit d23207e into merge-train/avm Jan 8, 2026
14 of 16 checks passed
@fcarreiro fcarreiro deleted the db/map-get-guards branch January 8, 2026 19:52
@AztecBot AztecBot mentioned this pull request Jan 8, 2026
Merged
github-merge-queue bot pushed a commit that referenced this pull request Jan 9, 2026
@AztecBot
feat: merge-train/avm (#19422)
2dc5653 
BEGIN_COMMIT_OVERRIDE
feat(avm)!: dont expose/require VK (#19414)
chore(avm): params should be references
chore: defensive asserts for map/vector retrievals and optional values
in cpp (#19439)
END_COMMIT_OVERRIDE
github-actions bot pushed a commit that referenced this pull request Jan 9, 2026
@dbanks12
chore: defensive asserts for map/vector retrievals and optional value…
72da622 
…s in cpp (#19439)

To prevent crashes in worst-case scenarios
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fcarreiro fcarreiro fcarreiro approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@dbanks12 @AztecBot @fcarreiro