Skip to content

Improve delete site focus tab and selected site id #2480

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
sejas wants to merge 5 commits into
base: trunk
Choose a base branch
from
Open

Improve delete site focus tab and selected site id #2480

sejas wants to merge 5 commits into from
+14 −10

Conversation

@sejas
Copy link
Member

@sejas sejas commented Jan 26, 2026

Related issues

Proposed Changes

  • Fix delete site behaviour but keep the logic simple

Testing Instructions

Pre-merge Checklist

  • Have you checked for TypeScript, React or other console errors?

gcsecsey and others added 5 commits January 23, 2026 16:11
@gcsecsey
Update tab selection logic after site deletion
b5302e3 
- Update the logic to reset the selected tab to 'overview' only if the currently selected site no longer exists and a selection change has occurred.
- Improve clarity in comments regarding selection changes and tab resets.
@gcsecsey
move tab update into selection update
54480ec
@gcsecsey
move site detection out of state handler
c5bbcf3
@gcsecsey
move the tab update to SiteContentTabs
adf5429
@sejas
Simplify logic by using useRef selectedSiteId
86a88f2
@sejas sejas changed the title Update/stu 1241 when deleting site focus always moves to the first site Improve delete site focus tab and selected site id Jan 26, 2026
@sejas sejas mentioned this pull request Jan 26, 2026
Open
1 task
@sejas sejas self-assigned this Jan 26, 2026
@sejas sejas requested a review from gcsecsey January 26, 2026 20:01
@wpmobilebot
Copy link

wpmobilebot commented Jan 26, 2026

📊 Performance Test Results

Comparing 86a88f2 vs trunk

site-editor

Metric trunk 86a88f2 Diff Change
load 2912.00 ms 2895.00 ms -17.00 ms 🟢 -0.6%

site-startup

Metric trunk 86a88f2 Diff Change
siteCreation 7076.00 ms 7077.00 ms +1.00 ms 🔴 0.0%
siteStartup 3927.00 ms 3941.00 ms +14.00 ms 🔴 0.4%

Results are median values from multiple test runs.

Legend: 🟢 Improvement (faster) | 🔴 Regression (slower) | ⚪ No change

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gcsecsey gcsecsey Awaiting requested review from gcsecsey

At least 1 approving review is required to merge this pull request.

Assignees

@sejas sejas

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@sejas @wpmobilebot @gcsecsey