Update tab selection logic after site deletion

[gcsecsey]

Related issues

• Fixes STU-1241
• Follow-up to Update site selection behavior after site deletion #2459

Proposed Changes

When the deleted site was the selected site, the tab should reset to "Overview". However, calling setSelectedTab('overview') from the site details hook didn't work reliably. The ContentTabsProvider wraps SiteDetailsProvider, so when both states update, the site change renders the component before the tab update takes effect, causing the TabPanel to remount with the old tab value.

This PR moves the state update call from the onDeleteSite callback to SiteContentTabs, and adds logic to compute an effectiveTab value at render time. The component tracks the previous site ID in state and, during render, checks if the site changed AND the previous site was deleted. If both conditions are true, it uses 'overview' as the effective tab for initialTabName. A useEffect then syncs this back to the tab context.

Testing Instructions

1. Start Studio with npm start
2. Create three sites (Site 1, Site 2, Site 3)
3. Delete Site 3
4. While the deletion is going on, quickly select Site 2 and switch to the "Sync" tab or any other tab
5. Check that after the deletion, Site 2 and the previously selected tab remain selected
6. Delete Site 2, and stay on the Settings tab until the deletion is completed
7. Check that Site 1 on the Overview tab is selected after the deletion

CleanShot.2026-01-26.at.11.09.23.mp4

Pre-merge Checklist

• Have you checked for TypeScript, React or other console errors?

[wpmobilebot]

📊 Performance Test Results

Comparing 27d6e4d vs trunk

site-editor

Metric	trunk	27d6e4d	Diff	Change
load	2904.00 ms	2901.00 ms	-3.00 ms	🟢 -0.1%

site-startup

Metric	trunk	27d6e4d	Diff	Change
siteCreation	8082.00 ms	7103.00 ms	-979.00 ms	🟢 -12.1%
siteStartup	3938.00 ms	3935.00 ms	-3.00 ms	🟢 -0.1%

---

Results are median values from multiple test runs.

Legend: 🟢 Improvement (faster) | 🔴 Regression (slower) | ⚪ No change

[sejas]

I tested it and it mostly worked, the only issue is that my selected site changed from one existing site to another automatically.
Steps to reproduce:

• Delete site 3
• Quickly switch to site 2
• Observe that Studio switches automatically to the first site instead of keeping you in the existing site 2.

Here is a recording:

test-deleting-sites-and-tabs.mp4

[sejas]

@gcsecsey , thanks for making the changes. I tested it and it works as expected, althoug I think we added more changes in site-content-tabs whcih I think are not necesssary.

I created this alternate PR using yours as base and it seems to work. #2480

[sejas]

Works as expected! Great work!

[sejas]

Maybe we could isolate these new hooks into separate custom hook.

[gcsecsey]

Thanks @sejas that's a good suggestion. I moved it to a new hook in 27d6e4d.

[epeicher]

Thanks @gcsecsey for solving this! I have tested it, and it works as expected. The site selected and the tab selected remains after the site deletion completes. I have also confirmed that if no other sites are selected, the first site in the Overview tab is opened. Changes also LGTM!