Skip to content

fix(mobile): track-player RN 0.79 compat + fmt consteval for Xcode 26 #14397

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
raymondjacobson wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix(mobile): track-player RN 0.79 compat + fmt consteval for Xcode 26 #14397

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f9b4610
fix(mobile): Xcode 26 SDK for iOS upload + hermesc path for Android
raymondjacobson May 23, 2026
5c33422
fix(mobile): track-player RN0.79 compat + fmt consteval for Xcode 26
raymondjacobson May 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/mobile.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -432,7 +432,7 @@ jobs:
# iOS Release Candidate: Build and upload
mobile-build-upload-releasecandidate-ios:
name: iOS Release Candidate Build & Upload
runs-on: macos-15
runs-on: macos-26
needs: [mobile-install, mobile-version-check]
if: github.ref == 'refs/heads/main' && github.event_name != 'pull_request' && needs.mobile-version-check.outputs.version_changed == 'true'
steps:
Expand Down Expand Up @@ -834,7 +834,7 @@ jobs:
# iOS Production: Build and upload (requires approval)
mobile-build-upload-production-ios-main:
name: iOS Production Build & Upload
runs-on: macos-15
runs-on: macos-26
needs: [mobile-install, mobile-version-check]
if: github.ref == 'refs/heads/main' && github.event_name != 'pull_request' && needs.mobile-version-check.outputs.version_changed == 'true'
environment:
Expand Down
47 changes: 25 additions & 22 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

9 changes: 7 additions & 2 deletions packages/mobile/android/app/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,12 @@ react {
// extraPackagerArgs = []
/* Hermes Commands */
// The hermes compiler command to run. By default it is 'hermesc'
// hermesCommand = "$rootDir/my-custom-hermesc/bin/hermesc"
// The RN Gradle plugin's hermesc lookup is anchored at `root` and only
// considers `root/node_modules/react-native/sdks/hermesc/...`. Since RN
// is hoisted to the monorepo node_modules, that lookup fails. Point the
// plugin at the hoisted prebuilt hermesc explicitly (%OS-BIN% is
// substituted by the plugin at runtime).
hermesCommand = "$rootDir/../../../node_modules/react-native/sdks/hermesc/%OS-BIN%/hermesc"
//
// The list of flags to pass to the Hermes compiler. By default is "-O", "-output-source-map"
// hermesFlags = ["-O", "-output-source-map"]
Expand Down Expand Up @@ -129,7 +134,7 @@ android {
// versionCode is automatically incremented in CI
versionCode 1
// Make sure this is above the currently released Android version in the play store if your changes touch native code:
versionName "1.1.531"
versionName "1.1.533"
resValue "string", "build_config_package", "co.audius.app"
resConfigs "en"
}
Expand Down
2 changes: 1 addition & 1 deletion packages/mobile/ios/AudiusReactNative/Info.plist
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
<key>CFBundlePackageType</key>
<string>APPL</string>
<key>CFBundleShortVersionString</key>
<string>1.1.195</string>
<string>1.1.197</string>
<key>CFBundleSignature</key>
<string>????</string>
<key>CFBundleURLTypes</key>
Expand Down
2 changes: 1 addition & 1 deletion packages/mobile/ios/Gemfile.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -302,7 +302,7 @@ DEPENDENCIES
bigdecimal
cocoapods (>= 1.13, != 1.15.1, != 1.15.0)
concurrent-ruby (< 1.3.4)
fastlane (>= 2.228.0)
fastlane (= 2.234.0)
fastlane-plugin-versioning
logger
mutex_m
Expand Down
16 changes: 16 additions & 0 deletions packages/mobile/ios/Podfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,6 +97,22 @@ target 'AudiusReactNative' do
end
end

# Xcode 26 / Apple Clang enforces stricter consteval evaluation, which
# breaks the fmt 11.0.2 that React Native 0.79 pins:
# Pods/fmt/include/fmt/format-inl.h:59: error: call to consteval
# function 'fmt::basic_format_string<...>' is not a constant expression
# FMT_USE_CONSTEVAL=0 forces the constexpr fallback. Fixed upstream in
# fmt 11.1+ / RN 0.80; this is a stopgap until we upgrade RN.
installer.pods_project.targets.each do |target|
next unless target.name == 'fmt'
target.build_configurations.each do |config|
defs = config.build_settings['GCC_PREPROCESSOR_DEFINITIONS'] || ['$(inherited)']
defs = [defs] unless defs.is_a?(Array)
defs << 'FMT_USE_CONSTEVAL=0' unless defs.include?('FMT_USE_CONSTEVAL=0')
config.build_settings['GCC_PREPROCESSOR_DEFINITIONS'] = defs
end
end

end
end

4 changes: 2 additions & 2 deletions packages/mobile/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@audius/mobile",
"version": "1.5.182",
"version": "1.5.184",
"private": true,
"scripts": {
"android:dev": "ENVFILE=.env.dev turbo run android -- --mode=prodDebug",
Expand Down Expand Up @@ -149,7 +149,7 @@
"react-native-svg": "^15.11.2",
"react-native-svg-transformer": "1.5.0",
"react-native-tab-view": "4.2.0",
"react-native-track-player": "4.0.1",
"react-native-track-player": "4.1.2",
"react-native-url-polyfill": "2.0.0",
"react-native-version-number": "0.3.6",
"react-native-video": "6.18.0",
Expand Down