fix(mobile): track-player RN 0.79 compat + fmt consteval for Xcode 26#14397
Open
raymondjacobson wants to merge 2 commits into
Open
fix(mobile): track-player RN 0.79 compat + fmt consteval for Xcode 26#14397raymondjacobson wants to merge 2 commits into
raymondjacobson wants to merge 2 commits into
Conversation
Two real failures surfaced in run 26319345276 after the displayer fix in #14394 made fastlane log altool errors again: ### iOS RC + Prod — Apple now requires iOS 26 SDK altool 409 Validation failed: This app was built with the iOS 18.5 SDK. All iOS and iPadOS apps must be built with the iOS 26 SDK or later, included in Xcode 26 or later, in order to be uploaded to App Store Connect or submitted for distribution. (ID: 287c542e-…) The `macos-15` runners default to Xcode 16.4 (iOS 18.5 SDK). Switch both iOS upload jobs to `macos-26` (Tahoe, GA), which has Xcode 26 as the only supported major. ### Android RC + Prod — hermesc location anchored at the wrong root Couldn't determine Hermesc location. Please set `react.hermesCommand` to the path of the hermesc binary file. node_modules/react-native/sdks/hermesc/%OS-BIN%/hermesc The previous PR restored `react.root` to its default (`../..` = `packages/mobile`) to fix the Hermes JS bundle's entryFile lookup. The same plugin uses `root` to detect the prebuilt hermesc binary (PathUtils.kt#detectOSAwareHermesCommand) and only checks `root/node_modules/react-native/sdks/hermesc/...`. Since RN is hoisted to the monorepo node_modules, that lookup fails. Set `react.hermesCommand` explicitly to the hoisted prebuilt path: $rootDir/../../../node_modules/react-native/sdks/hermesc/%OS-BIN%/hermesc The `%OS-BIN%` placeholder is substituted at runtime by the plugin to `linux64-bin` / `osx-bin` / `win64-bin` as appropriate. Verified those bin directories exist in node_modules/react-native/sdks/hermesc/ in this branch. ### Housekeeping - `Gemfile.lock` dependency line aligned to `= 2.234.0` to match the Gemfile pin from #14394 (the squash-merge left the lock at the pre-pin `>= 2.228.0` constraint). - Bump versions to re-fire the build matrix: `1.5.182 -> 1.5.183`, iOS `1.1.195 -> 1.1.196`, Android `1.1.531 -> 1.1.532`. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
After #14396 the Hermesc + Xcode 26 runner fixes both worked. The binary build matrix now actually compiles, and surfaced two remaining upstream-library incompatibilities with React Native 0.79 + Xcode 26. ### Android RC + Prod — react-native-track-player onBind signature Kotlin compile failed on the bundled `react-native-track-player`: e: .../trackplayer/service/MusicService.kt:764:5 'onBind' overrides nothing. RN 0.79's HeadlessJsTaskService now declares: override fun onBind(intent: Intent): IBinder? = null ^^^^^^ ^^^^^^^^^^ react-native-track-player 4.0.1 still has the old signature: override fun onBind(intent: Intent?): IBinder ^^^^^^^ ^^^^^^^ Kotlin parameter types must match the override exactly (return types can be covariant, parameter types cannot). 4.1.2 already matches RN 0.79's signature, so bumping the dep is the fix. packages/mobile/package.json: 4.0.1 -> 4.1.2 package-lock.json regenerated. ### iOS RC + Prod — fmt consteval error under Xcode 26 / Apple Clang xcodebuild archive failed on the fmt Pod: Pods/fmt/include/fmt/format-inl.h:59: error: call to consteval function 'fmt::basic_format_string<...>' is not a constant expression 59 | fmt::format_to(it, FMT_STRING("{}{}"), message, SEP); RN 0.79 pins fmt 11.0.2 via third-party-podspecs/fmt.podspec. Apple Clang in Xcode 26 enforces stricter consteval evaluation than the version 11.0.2 was written against. Fixed upstream in fmt 11.1+ (RN 0.80 picks up the newer fmt); for 0.79 the workaround is to define FMT_USE_CONSTEVAL=0 on the fmt target, falling back to the constexpr implementation. Add a Podfile post_install hook that injects the define for the fmt target only. CI's existing `bundle exec pod install` step will pick up the change without lockfile churn. ### Re-trigger the release flow - packages/mobile/package.json: 1.5.183 -> 1.5.184 - iOS Info.plist CFBundleShortVersionString: 1.1.196 -> 1.1.197 - Android versionName: 1.1.532 -> 1.1.533 Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
#14396 unblocked the runner + hermesc issues. The binary build matrix now actually compiles and surfaces two real upstream-library incompatibilities with React Native 0.79 + Xcode 26 in run 26320122339.
1. Android RC + Prod — `react-native-track-player@4.0.1` is incompatible with RN 0.79
Kotlin compile error at `react-native-track-player` against the updated `HeadlessJsTaskService` in RN 0.79:
```
e: file://.../react-native-track-player/android/src/main/java/com/doublesymmetry/trackplayer/service/MusicService.kt:764:5
'onBind' overrides nothing.
```
RN 0.79's `HeadlessJsTaskService.kt:58` now declares:
```kotlin
override fun onBind(intent: Intent): IBinder? = null
```
but `react-native-track-player@4.0.1` still has the pre-0.79 signature:
```kotlin
override fun onBind(intent: Intent?): IBinder
```
Kotlin allows covariant return types but not contravariant parameter types — `Intent?` ≠ `Intent` for override matching, so the compiler errors. `react-native-track-player@4.1.2` already matches RN 0.79's signature, so bumping the dep is the fix.
2. iOS RC + Prod — `fmt 11.0.2` consteval fails under Xcode 26 / Apple Clang
xcodebuild archive failed compiling the `fmt` Pod:
```
Pods/fmt/include/fmt/format-inl.h:59: error: call to consteval function
'fmt::basic_format_string<...>' is not a constant expression
59 | fmt::format_to(it, FMT_STRING("{}{}"), message, SEP);
```
RN 0.79 pins fmt 11.0.2 via `third-party-podspecs/fmt.podspec`. Apple Clang in Xcode 26 enforces stricter `consteval` evaluation than 11.0.2 was written against. Fixed upstream in fmt 11.1+ (RN 0.80 picks up the newer fmt); for 0.79 the standard workaround is `-DFMT_USE_CONSTEVAL=0`, which falls back to the constexpr implementation.
Add a Podfile post_install hook that injects `FMT_USE_CONSTEVAL=0` into `GCC_PREPROCESSOR_DEFINITIONS` for the `fmt` target only. CI's existing `bundle exec pod install` step picks up the change with no lockfile churn.
Re-trigger the release flow
Test plan
🤖 Generated with Claude Code