Skip to content

fix: Fix ValueError when passing evals_dataframe to spans.log() #123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nluzio wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: Fix ValueError when passing evals_dataframe to spans.log() #123

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/arize/spans/client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,7 +143,7 @@ def log(
# We expect the index to be 0,1,2,3..., len(df)-1. Phoenix, for example, will give us a dataframe
# with context_id as the index
reset_dataframe_index(dataframe=spans_df)
if evals_df:
if evals_df is not None:
reset_dataframe_index(dataframe=evals_df)

log.debug("Performing direct input type validation")
Expand Down Expand Up @@ -183,7 +183,7 @@ def log(
df=spans_df,
column_list=[col.name for col in SPAN_OPENINFERENCE_COLUMNS],
)
if evals_df:
if evals_df is not None:
evals_df = remove_extraneous_columns(
df=evals_df,
column_list=[SPAN_SPAN_ID_COL.name],
Expand All @@ -199,7 +199,7 @@ def log(
spans_dataframe=spans_df,
project_name=project_name,
)
if evals_df:
if evals_df is not None:
eval_errors = evals_validation.validate_values(
evals_dataframe=evals_df,
project_name=project_name,
Expand All @@ -224,7 +224,7 @@ def log(

df = (
pd.merge(spans_df, evals_df, on=SPAN_SPAN_ID_COL.name, how="left")
if evals_df
if evals_df is not None
else spans_df
)

Expand Down