fix: Fix ValueError when passing evals_dataframe to spans.log()#123
Open
fix: Fix ValueError when passing evals_dataframe to spans.log()#123
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix ValueError when passing evals_dataframe to spans.log()
Problem
When calling
spans.log()with both a dataframe and an evals_dataframe, the methodwould fail with:
ValueError: The truth value of a DataFrame is ambiguous. Use a.empty, a.bool(),
a.item(), a.any() or a.all().
This occurred because the code was using
if evals_df:to check if the evaldataframe exists, but pandas DataFrames cannot be evaluated directly in a boolean
context.
Solution
Changed all boolean checks on
evals_dffromif evals_df:toif evals_df is not None:to properly check for the existence of the dataframe.Changes
Fixed 4 instances in
src/arize/spans/client.py:The code already used the correct pattern (
is not None) in some places but wasinconsistent.