test: docker discovery + copilot provider compatibility

[anandgupta42]

What does this PR do?

Adds 20 new tests covering two previously untested modules discovered during proactive test discovery.

1. containerToConfig — src/altimate/native/connections/docker-discovery.ts (6 new tests)

This function converts discovered Docker containers into ConnectionConfig objects used to connect to databases. Zero tests existed. When users run warehouse auto-discovery with Docker, incorrect config generation would silently produce broken connections (wrong type, leaked Docker-specific fields, missing credentials).

New coverage includes:

• Full container conversion with all optional fields (user, password, database)
• Omission of optional fields when not present on the container
• Correct db_type → config.type mapping across all supported database types
• Partial field presence (user without password, database without credentials)
• Ensuring Docker-specific metadata (container_id, name, image, status) does not leak into ConnectionConfig

2. mapOpenAICompatibleFinishReason and getResponseMetadata — src/provider/sdk/copilot/chat/ (14 new tests)

These utility functions power the GitHub Copilot provider integration. mapOpenAICompatibleFinishReason translates OpenAI-style finish reasons into the AI SDK's LanguageModelV2FinishReason enum. An incorrect mapping (e.g., tool_calls → unknown instead of tool-calls) would cause the system to misinterpret model responses, potentially dropping tool call results. getResponseMetadata converts Unix epoch timestamps to Date objects for response tracking.

New coverage includes:

• All five known finish reason mappings (stop, length, content_filter, function_call, tool_calls)
• Null, undefined, and unrecognized string inputs falling back to unknown
• Full metadata conversion with id, model, and timestamp
• Null/undefined/missing input handling for all metadata fields
• Edge case: created=0 produces epoch Date (not undefined) — tests the != null guard

Type of change

• New feature (non-breaking change which adds functionality)

Issue for this PR

N/A — proactive test coverage

How did you verify your code works?

bun test test/altimate/docker-discovery.test.ts   # 6 pass, 23 expect() calls
bun test test/provider/copilot-compat.test.ts      # 14 pass, 24 expect() calls

Checklist

• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes

https://claude.ai/code/session_01J8xz7ijLjbzEe3mu7ajdWh

Summary by CodeRabbit

• Tests
  • Added comprehensive test coverage for Docker container configuration conversion, validating proper field mapping and handling of optional parameters.
  • Added test coverage for Copilot SDK compatibility helpers, ensuring correct transformation of finish reasons and response metadata parsing.

[claude]

Claude Code Review

This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.

_{Tip: disable this comment in your organization's Code Review settings.}

[coderabbitai]

📝 Walkthrough

Walkthrough

Two new test files are added to the OpenCode package. The first tests conversion of Docker containers into connection configurations, verifying correct handling of all fields and optional properties. The second tests Copilot-compatible SDK helpers, validating finish reason mappings and response metadata transformations.

Changes

Cohort / File(s)	Summary
Docker Discovery Tests packages/opencode/test/altimate/docker-discovery.test.ts	New test suite for containerToConfig function covering field mapping from DockerContainer to ConnectionConfig, optional field handling, and validation that Docker-specific fields are not included in output.
Copilot Compatibility Tests packages/opencode/test/provider/copilot-compat.test.ts	New test suite for two SDK helpers: mapOpenAICompatibleFinishReason (validating reason mappings including edge cases) and getResponseMetadata (verifying transformation of response fields with timestamp conversion).

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~15 minutes

Suggested labels

contributor

Poem

🐰 Two test files hop into view,
Docker configs and OpenAI too,
With assertions that verify the way,
Coverage blooms bright as the day!
The rabbit's tests run true and straight,
Quality code—it's simply great! ✨

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly and concisely summarizes the main changes: adding tests for docker discovery and copilot provider compatibility modules.
Description check	✅ Passed	The description comprehensively covers all required template sections with detailed explanations of what changed, why, and how it was tested, though explicit checklist completion is embedded in narrative form.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch test/hourly-20260328-1414

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

🧹 Nitpick comments (2)

packages/opencode/test/altimate/docker-discovery.test.ts (2)

52-68: Consider using test.each for better test isolation and output.

The for-loop approach works, but if any iteration fails, subsequent iterations won't run. Using test.each provides isolated test cases with clearer reporting.

Suggested refactor

-  test("preserves db_type as config.type for all supported databases", () => {
-    const dbTypes = ["postgres", "mysql", "sqlserver", "oracle", "duckdb", "sqlite", "mongodb"]
-
-    for (const dbType of dbTypes) {
-      const container: DockerContainer = {
-        container_id: "x",
-        name: `test-${dbType}`,
-        image: `${dbType}:latest`,
-        db_type: dbType,
-        host: "127.0.0.1",
-        port: 5432,
-        status: "running",
-      }
-      const config = containerToConfig(container)
-      expect(config.type).toBe(dbType)
-    }
-  })
+  test.each(["postgres", "mysql", "sqlserver", "oracle", "duckdb", "sqlite", "mongodb"])(
+    "preserves db_type=%s as config.type",
+    (dbType) => {
+      const container: DockerContainer = {
+        container_id: "x",
+        name: `test-${dbType}`,
+        image: `${dbType}:latest`,
+        db_type: dbType,
+        host: "127.0.0.1",
+        port: 5432,
+        status: "running",
+      }
+      const config = containerToConfig(container)
+      expect(config.type).toBe(dbType)
+    }
+  )

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@packages/opencode/test/altimate/docker-discovery.test.ts` around lines 52 -
68, Replace the looped assertion with isolated parameterized tests using Jest's
test.each to improve failure isolation and reporting: convert the for..of over
dbTypes in the test that calls containerToConfig into a
test.each([...dbTypes])(...) table-driven test that constructs the
DockerContainer object (container) per case and asserts
expect(config.type).toBe(dbType); keep the same fields and values (container_id,
name, image, db_type, host, port, status) and reference the containerToConfig
function and dbTypes values so each db type runs as its own test case.

---

5-5: Describe block name is misleading.

The describe block is named "full container with all fields" but contains tests for omission of optional fields, partial fields, and metadata exclusion. Consider renaming to just "containerToConfig" to accurately reflect the scope.

Suggested fix

-describe("containerToConfig: full container with all fields", () => {
+describe("containerToConfig", () => {

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@packages/opencode/test/altimate/docker-discovery.test.ts` at line 5, Rename
the misleading describe block title "containerToConfig: full container with all
fields" to simply "containerToConfig" so the block accurately reflects that it
tests various cases (optional omissions, partial fields, metadata exclusion);
locate the describe call string in the test file (the describe(...) that
currently reads "containerToConfig: full container with all fields") and update
it to "containerToConfig", and if any nested test descriptions or snapshots rely
on the old describe title, adjust those references to match the new describe
name.

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Nitpick comments:
In `@packages/opencode/test/altimate/docker-discovery.test.ts`:
- Around line 52-68: Replace the looped assertion with isolated parameterized
tests using Jest's test.each to improve failure isolation and reporting: convert
the for..of over dbTypes in the test that calls containerToConfig into a
test.each([...dbTypes])(...) table-driven test that constructs the
DockerContainer object (container) per case and asserts
expect(config.type).toBe(dbType); keep the same fields and values (container_id,
name, image, db_type, host, port, status) and reference the containerToConfig
function and dbTypes values so each db type runs as its own test case.
- Line 5: Rename the misleading describe block title "containerToConfig: full
container with all fields" to simply "containerToConfig" so the block accurately
reflects that it tests various cases (optional omissions, partial fields,
metadata exclusion); locate the describe call string in the test file (the
describe(...) that currently reads "containerToConfig: full container with all
fields") and update it to "containerToConfig", and if any nested test
descriptions or snapshots rely on the old describe title, adjust those
references to match the new describe name.

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 47d4da55-e73d-41cf-8502-b28e3116db8e

📥 Commits

Reviewing files that changed from the base of the PR and between 9ba2114 and 72819b1.

📒 Files selected for processing (2)

• packages/opencode/test/altimate/docker-discovery.test.ts
• packages/opencode/test/provider/copilot-compat.test.ts

[anandgupta42]

Consolidated into #545