test: consolidate 18 test PRs — 434 new tests, deduplicated, with bug fixes

Consolidates PRs #515, #526, #527, #528, #530, #531, #532, #533, #534,
#535, #536, #537, #538, #539, #540, #541, #542, #543 into a single PR.

Changes:
- 30 files changed, ~3000 lines of new test coverage
- Deduplicated redundant tests:
  - `copilot-compat.test.ts`: removed duplicate `mapOpenAICompatibleFinishReason`
    tests (already covered in `copilot/finish-reason.test.ts`)
  - `lazy.test.ts`: removed duplicate error-retry and `reset()` tests
  - `transform.test.ts`: kept most comprehensive version (#535) over
    subset PRs (#539, #541)
- Bug fixes from PR #528:
  - `extractEquivalenceErrors`: `null` entries in `validation_errors`
    crashed with TypeError (`null.message` throws before `??` evaluates).
    Fixed with optional chaining: `e?.message`
  - `extractSemanticsErrors`: same fix applied
  - Updated test from `expect(...).toThrow(TypeError)` to verify the fix

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Author: anandgupta42

.github/meta/commit.txt

@@ -1,8 +1,21 @@
-release: v0.5.11
+test: consolidate 18 test PRs — 434 new tests, deduplicated, with bug fixes
 
-Update README changelog to reflect releases v0.5.1 through v0.5.11.
-Previous README only listed up to v0.5.0, missing 10 versions of features
-including `check` CLI, skill management, session tracing, Codespaces support,
-impact analysis, Snowflake Cortex, MCP auto-discovery, and more.
+Consolidates PRs #515, #526, #527, #528, #530, #531, #532, #533, #534,
+#535, #536, #537, #538, #539, #540, #541, #542, #543 into a single PR.
+
+Changes:
+- 30 files changed, ~3000 lines of new test coverage
+- Deduplicated redundant tests:
+  - `copilot-compat.test.ts`: removed duplicate `mapOpenAICompatibleFinishReason`
+    tests (already covered in `copilot/finish-reason.test.ts`)
+  - `lazy.test.ts`: removed duplicate error-retry and `reset()` tests
+  - `transform.test.ts`: kept most comprehensive version (#535) over
+    subset PRs (#539, #541)
+- Bug fixes from PR #528:
+  - `extractEquivalenceErrors`: `null` entries in `validation_errors`
+    crashed with TypeError (`null.message` throws before `??` evaluates).
+    Fixed with optional chaining: `e?.message`
+  - `extractSemanticsErrors`: same fix applied
+  - Updated test from `expect(...).toThrow(TypeError)` to verify the fix
 
 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

packages/opencode/src/altimate/tools/altimate-core-equivalence.ts

@@ -68,7 +68,7 @@ export const AltimateCoreEquivalenceTool = Tool.define("altimate_core_equivalenc
 export function extractEquivalenceErrors(data: Record<string, any>): string | undefined {
   if (Array.isArray(data.validation_errors) && data.validation_errors.length > 0) {
     const msgs = data.validation_errors
-      .map((e: any) => (typeof e === "string" ? e : (e.message ?? String(e))))
+      .map((e: any) => (typeof e === "string" ? e : (e?.message ?? String(e))))
       .filter(Boolean)
     return msgs.length > 0 ? msgs.join("; ") : undefined
   }

packages/opencode/src/altimate/tools/altimate-core-semantics.ts

@@ -64,7 +64,7 @@ export const AltimateCoreSemanticsTool = Tool.define("altimate_core_semantics",
 export function extractSemanticsErrors(data: Record<string, any>): string | undefined {
   if (Array.isArray(data.validation_errors) && data.validation_errors.length > 0) {
     const msgs = data.validation_errors
-      .map((e: any) => (typeof e === "string" ? e : (e.message ?? String(e))))
+      .map((e: any) => (typeof e === "string" ? e : (e?.message ?? String(e))))
       .filter(Boolean)
     return msgs.length > 0 ? msgs.join("; ") : undefined
   }

packages/opencode/test/altimate/altimate-core-equivalence-formatters.test.ts

@@ -36,11 +36,11 @@ describe("extractEquivalenceErrors", () => {
     expect(extractEquivalenceErrors(data)).toBe("42")
   })
 
-  test("crashes on null entries in validation_errors (known bug)", () => {
-    // BUG: null passes typeof check (not "string") but null.message throws TypeError
-    // The ?? operator cannot protect because property access on null throws first
-    const data = { validation_errors: [null] }
-    expect(() => extractEquivalenceErrors(data)).toThrow(TypeError)
+  test("handles null entries in validation_errors without crashing", () => {
+    // Previously crashed: null.message throws TypeError before ?? can evaluate
+    // Fixed with optional chaining: e?.message ?? String(e)
+    const data = { validation_errors: [null, "real error"] }
+    expect(extractEquivalenceErrors(data)).toBe("null; real error")
   })
 
   test("filters out falsy messages", () => {

packages/opencode/test/provider/copilot-compat.test.ts

@@ -1,42 +1,7 @@
 import { describe, test, expect } from "bun:test"
-import { mapOpenAICompatibleFinishReason } from "../../src/provider/sdk/copilot/chat/map-openai-compatible-finish-reason"
 import { getResponseMetadata } from "../../src/provider/sdk/copilot/chat/get-response-metadata"
 
-describe("mapOpenAICompatibleFinishReason", () => {
-  test("maps 'stop' to 'stop'", () => {
-    expect(mapOpenAICompatibleFinishReason("stop")).toBe("stop")
-  })
-
-  test("maps 'length' to 'length'", () => {
-    expect(mapOpenAICompatibleFinishReason("length")).toBe("length")
-  })
-
-  test("maps 'content_filter' to 'content-filter'", () => {
-    expect(mapOpenAICompatibleFinishReason("content_filter")).toBe("content-filter")
-  })
-
-  test("maps 'function_call' to 'tool-calls'", () => {
-    expect(mapOpenAICompatibleFinishReason("function_call")).toBe("tool-calls")
-  })
-
-  test("maps 'tool_calls' to 'tool-calls'", () => {
-    expect(mapOpenAICompatibleFinishReason("tool_calls")).toBe("tool-calls")
-  })
-
-  test("maps null to 'unknown'", () => {
-    expect(mapOpenAICompatibleFinishReason(null)).toBe("unknown")
-  })
-
-  test("maps undefined to 'unknown'", () => {
-    expect(mapOpenAICompatibleFinishReason(undefined)).toBe("unknown")
-  })
-
-  test("maps unrecognized string to 'unknown'", () => {
-    expect(mapOpenAICompatibleFinishReason("cancelled")).toBe("unknown")
-    expect(mapOpenAICompatibleFinishReason("error")).toBe("unknown")
-    expect(mapOpenAICompatibleFinishReason("")).toBe("unknown")
-  })
-})
+// mapOpenAICompatibleFinishReason tests live in copilot/finish-reason.test.ts
 
 describe("getResponseMetadata", () => {
   test("converts all fields when present", () => {

packages/opencode/test/util/lazy.test.ts

@@ -91,43 +91,4 @@ describe("util.lazy", () => {
     expect(lazyUndefined()).toBe(undefined)
   })
 
-  // altimate_change start — error recovery and reset tests
-  test("retries initialization after a throw (does not cache failures)", () => {
-    let attempt = 0
-    const lazyValue = lazy(() => {
-      attempt++
-      if (attempt === 1) throw new Error("init failed")
-      return "recovered"
-    })
-
-    expect(() => lazyValue()).toThrow("init failed")
-    expect(attempt).toBe(1)
-
-    // Second call should retry, not return cached error
-    const result = lazyValue()
-    expect(result).toBe("recovered")
-    expect(attempt).toBe(2)
-
-    // Third call should use cached value
-    const result2 = lazyValue()
-    expect(result2).toBe("recovered")
-    expect(attempt).toBe(2)
-  })
-
-  test("reset() allows re-initialization", () => {
-    let callCount = 0
-    const lazyValue = lazy(() => {
-      callCount++
-      return callCount
-    })
-
-    expect(lazyValue()).toBe(1)
-    expect(lazyValue()).toBe(1)
-
-    lazyValue.reset()
-
-    expect(lazyValue()).toBe(2)
-    expect(lazyValue()).toBe(2)
-  })
-  // altimate_change end
 })