test: provider — temperature, topP, topK model parameter defaults

[anandgupta42]

What does this PR do?

1. ProviderTransform.temperature(), topP(), topK() — src/provider/transform.ts (30 new tests)

These three pure functions are the sole source of model-specific sampling parameter defaults used by the LLM streaming pipeline (session/llm.ts lines 124-128). They map model IDs (via substring matching) to temperature, top-P, and top-K values for Qwen, Claude, Gemini, GLM, MiniMax, and Kimi model families. Despite being critical to output quality, they had zero dedicated unit tests — the existing 2655-line transform.test.ts only referenced temperature as a mock property, never testing the actual functions.

Why it matters: These functions contain fragile substring-matching logic with overlapping patterns. For example:

• kimi-k2 has sub-variants (thinking, k2.5, k2p5, k2-5) that should return 1.0 while the base kimi-k2 returns 0.6
• minimax-m2 has sub-variants (m2., m25, m21) that return topK=40 while the base returns topK=20
• The topP function checks kimi-k2.5 and kimi-k2-5 as separate string literals

A regression in any of these branches silently degrades generation quality — users see poor outputs without any error message.

Specific scenarios covered:

• Each model family branch for all three functions (qwen, claude, gemini, glm, minimax, kimi)
• Kimi-k2 sub-branching: base (0.6) vs thinking/k2.5/k2p5/k2-5 variants (1.0)
• MiniMax-m2 sub-branching: base (topK=20) vs m2./m25/m21 variants (topK=40)
• TopP asymmetry: kimi-k2.5 (dot) and kimi-k2-5 (hyphen) both return 0.95, but plain kimi-k2 returns undefined
• Unknown models returning undefined for all three functions

Type of change

• New feature (non-breaking change which adds functionality)

Issue for this PR

N/A — proactive test coverage for untested model parameter defaults

How did you verify your code works?

bun test test/provider/transform.test.ts    # 140 pass (110 existing + 30 new)

Marker check passed: bun run script/upstream/analyze.ts --markers --base main --strict

Checklist

• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes

https://claude.ai/code/session_01WZthZmQczd51XXSjhiABNH

Summary by CodeRabbit

• Tests
  • Added comprehensive test coverage for parameter transformations across multiple AI model providers.

[claude]

Claude Code Review

This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.

_{Tip: disable this comment in your organization's Code Review settings.}

[coderabbitai]

📝 Walkthrough

Walkthrough

Added 123 lines of test coverage for ProviderTransform.temperature, ProviderTransform.topP, and ProviderTransform.topK methods. Tests validate numeric outputs across multiple model providers and verify that undefined is returned for unsupported models.

Changes

Cohort / File(s)	Summary
ProviderTransform Test Coverage packages/opencode/test/provider/transform.test.ts	Added comprehensive test cases for temperature, topP, and topK parameter transformation methods across various AI model providers (Qwen, Gemini, MiniMax, GLM, Kimi-K2), with assertions for expected numeric values and undefined returns for unsupported models.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Poem

🐰 With whiskers twitching in delight,
New tests shimmer, shining bright,
Each model checked from left to right,
Temperature and topP take flight,
Our code now covered, pure and tight! ✨

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately and concisely summarizes the main change: adding test coverage for three model parameter default functions (temperature, topP, topK).
Description check	✅ Passed	The description comprehensively covers what changed and why, includes detailed test scenarios, provides verification steps, and addresses all key template sections despite variations in format.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch test/hourly-20260328-1210

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

🧹 Nitpick comments (1)

packages/opencode/test/provider/transform.test.ts (1)

2662-2752: Optional: reduce repeated test helper setup.

const m = (id: string) => ({ id } as any) is duplicated across describes; extracting one shared helper (or table-driven inputs) would simplify future additions.

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@packages/opencode/test/provider/transform.test.ts` around lines 2662 - 2752,
Extract the duplicated test helper `const m = (id: string) => ({ id } as any)`
into a single shared helper at the top of the test file (or a common beforeAll
scope) and remove the per-describe redeclarations so all suites (e.g., usages in
ProviderTransform.temperature, ProviderTransform.topP, ProviderTransform.topK)
reuse it; update existing describes to call the shared `m` helper or convert
tests to table-driven form if preferred to reduce repetition when adding new
model cases.

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Nitpick comments:
In `@packages/opencode/test/provider/transform.test.ts`:
- Around line 2662-2752: Extract the duplicated test helper `const m = (id:
string) => ({ id } as any)` into a single shared helper at the top of the test
file (or a common beforeAll scope) and remove the per-describe redeclarations so
all suites (e.g., usages in ProviderTransform.temperature,
ProviderTransform.topP, ProviderTransform.topK) reuse it; update existing
describes to call the shared `m` helper or convert tests to table-driven form if
preferred to reduce repetition when adding new model cases.

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 3335bc85-e70a-4e8b-a50e-5b485f9baa86

📥 Commits

Reviewing files that changed from the base of the PR and between 9ba2114 and eb24377.

📒 Files selected for processing (1)

• packages/opencode/test/provider/transform.test.ts

[anandgupta42]

Consolidated into #545