test: provider — sampling parameter functions (temperature, topP, topK)

[anandgupta42]

What does this PR do?

Adds 28 new unit tests for three completely untested pure functions in the provider transform module that control LLM sampling behavior.

1. ProviderTransform.temperature() — src/provider/transform.ts:292-308 (11 new tests)

This function returns model-specific temperature values that directly affect output quality. Zero tests existed. A refactor or new model addition could silently break temperature for existing model families. New coverage includes:

• Qwen models → 0.55 (recommended by Qwen docs)
• Claude models → undefined (API-controlled)
• Gemini models → 1.0
• GLM-4.6/4.7 models → 1.0
• Minimax-M2 models → 1.0
• Kimi-K2 variant detection (4 separate patterns: thinking, k2., k2p, k2-5) each tested individually so single-branch deletions are caught
• Base Kimi-K2 → 0.6 (critical boundary vs. variants returning 1.0)
• Fallthrough to undefined for unknown models

2. ProviderTransform.topP() — src/provider/transform.ts:310-317 (7 new tests)

Controls nucleus sampling. Each model family pattern (kimi-k2.5, kimi-k2p5, kimi-k2-5) is tested individually to catch single-pattern regressions. Coverage includes:

• Qwen → 1, Minimax-M2/Gemini/Kimi-K2.5 variants → 0.95
• Fallthrough to undefined for non-matching models

3. ProviderTransform.topK() — src/provider/transform.ts:319-327 (10 new tests)

Controls top-K sampling with a tricky inner dispatch for Minimax-M2 versioned vs. base models. Each version pattern (m2., m25, m21) is tested separately. Coverage includes:

• Minimax-M2 versioned (m2.5/m25/m21) → 40 vs. base M2 → 20 (important boundary)
• Gemini → 64
• Fallthrough to undefined

Type of change

• New feature (non-breaking change which adds functionality)

Issue for this PR

N/A — proactive test coverage for untested sampling parameter logic

How did you verify your code works?

bun test test/provider/transform.test.ts    # 139 pass (111 existing + 28 new)

Checklist

• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes

https://claude.ai/code/session_011NoVCnMW9Kw6eh92ayU7GB

Summary by CodeRabbit

• Tests
  • Enhanced test coverage for sampling parameter transforms across multiple AI models (including temperature, topP, and topK parameters).

[claude]

Claude Code Review

This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.

_{Tip: disable this comment in your organization's Code Review settings.}

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 76324666-6fb2-41a8-a08f-ff937e77a6b2

📥 Commits

Reviewing files that changed from the base of the PR and between 9ba2114 and c55940b.

📒 Files selected for processing (1)

• packages/opencode/test/provider/transform.test.ts

---

📝 Walkthrough

Walkthrough

Added 127 lines of new test cases to packages/opencode/test/provider/transform.test.ts covering sampling parameter transforms. Tests verify that ProviderTransform.temperature, ProviderTransform.topP, and ProviderTransform.topK return expected numeric values based on model ID across multiple provider models including Qwen, Gemini, Minimax, and Kimi-K2.

Changes

Cohort / File(s)	Summary
Sampling Parameter Transform Tests packages/opencode/test/provider/transform.test.ts	Added comprehensive test suites for temperature, topP, and topK parameter transforms with assertions across multiple model variants and categories.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Suggested labels

contributor

Poem

🐰 A thousand models tested with care,
Temperature, topP, topK everywhere,
Each assertion's a carrot, each suite a delight,
The sampling parameters now shining bright! 🥕✨

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately and specifically summarizes the main change: adding tests for three sampling parameter functions (temperature, topP, topK) in the provider module.
Description check	✅ Passed	The description is comprehensive and follows the template structure with clear Summary and Test Plan sections, though it lacks explicit checklist items in the final output format.
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch test/hourly-20260328-0910

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[anandgupta42]

Consolidated into #545